Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update to react 19 #6552

Draft
wants to merge 36 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
c06d2d5
fix(actions): use correct reviewing team name
matthewgallo Dec 5, 2024
afed4da
build(deps): update to react 19
matthewgallo Dec 5, 2024
6dfb567
Merge branch 'main' into react-19-upgrade
matthewgallo Dec 5, 2024
82c45aa
fix: udpate lock
matthewgallo Dec 5, 2024
132e545
fix(sb): no custom labels with react 19, removed canary labels
matthewgallo Dec 6, 2024
1b2ba23
refactor: update prop validations part 1
matthewgallo Dec 6, 2024
4312092
refactor: remove action set validate actions references
matthewgallo Dec 6, 2024
9c84a8e
fix: update old prop type validation approach
matthewgallo Dec 9, 2024
181fd6e
fix: ignore test assertion until react 19 tabs issue is solved
matthewgallo Dec 9, 2024
4484542
chore: add to resolutions, remove test tab story
matthewgallo Dec 9, 2024
44706ae
fix(NotificationPanel): address open/close issue with panel
matthewgallo Dec 11, 2024
1222d5e
chore: remove leftover conditional
matthewgallo Dec 11, 2024
93cc37b
chore: cleanup page header story
matthewgallo Dec 11, 2024
4e4f60d
fix(NotificationsPanel): update test, make trigger prop required
matthewgallo Dec 11, 2024
2b31cbd
fix(APIKeyModal): tab to move focus to input
matthewgallo Dec 11, 2024
40d3f4e
refactor: remove remaining uses of .defaultProps
matthewgallo Dec 11, 2024
ec1b35c
Merge branch 'main' into react-19-upgrade
matthewgallo Dec 11, 2024
a61853e
refactor: pass undefined to createContext
matthewgallo Dec 12, 2024
072d347
Merge branch 'main' into react-19-upgrade
matthewgallo Dec 12, 2024
3edcad2
refactor: update types for Datagrid contexts
matthewgallo Dec 17, 2024
242a25d
Merge branch 'react-19-upgrade' of github.com:matthewgallo/ibm-produc…
matthewgallo Dec 17, 2024
381b830
Merge branch 'main' into react-19-upgrade
matthewgallo Dec 17, 2024
7ee2f77
chore: remove log
matthewgallo Dec 17, 2024
3e91322
chore: update lock
matthewgallo Dec 19, 2024
d18ecec
fix(Datagrid): check for empty obj in useFilterContext
matthewgallo Dec 19, 2024
ff633b9
chore: conflicts
matthewgallo Jan 6, 2025
f9b0728
fix: move types
matthewgallo Jan 6, 2025
24960c5
chore: merge main and fix conflict
matthewgallo Jan 14, 2025
698cc9e
fix(types): import JSX type from react package
matthewgallo Jan 14, 2025
92ef04f
refactor(Carousel): typescript fixes with forwarded ref
matthewgallo Jan 14, 2025
e64ad77
fix(Carousel): add ts issues
matthewgallo Jan 14, 2025
23a7ab0
fix: address cascade type issues
matthewgallo Jan 14, 2025
6aa7926
refactor: various type fixes
matthewgallo Jan 15, 2025
6ce6203
chore: merge main and fix conflict
matthewgallo Jan 15, 2025
063dcdd
chore: avt test
matthewgallo Jan 15, 2025
95d0b70
fix: provide default value in web terminal
matthewgallo Jan 15, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions e2e/components/APIKeyModal/APIKeyModal-test.avt.e2e.js
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ test.describe('APIKeyModal @avt', () => {
);
await expect(modalElement).toBeInViewport();
await expect(modalElement).not.toHaveAttribute('aria-hidden', 'true');
await page.keyboard.press('Tab');
await expect(apiKeyInput).toBeFocused();
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ test.describe('NotificationsPanel @avt', () => {
},
});

const notificationPanel = await page.locator(
const notificationPanel = page.locator(
`div#${pkg.prefix}--notifications-panel`
);
await expect(notificationPanel).toBeVisible();
Expand All @@ -45,12 +45,12 @@ test.describe('NotificationsPanel @avt', () => {
await firstElement.focus();
await expect(firstElement).toBeFocused();

const lastElement = page.locator(
await page.keyboard.press('Shift+Tab');
const lastElement = await page.locator(
`button.${pkg.prefix}--notifications-panel__settings-button`
);
await page.keyboard.press('Shift+Tab');
await expect(lastElement).toBeFocused();

await expect(lastElement).toBeFocused();
await page.keyboard.press('Tab');
await expect(firstElement).toBeFocused();

Expand Down
10 changes: 5 additions & 5 deletions examples/carbon-for-ibm-products/APIKeyModal/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,17 @@
"@carbon/ibm-products": "^2.21.0",
"@carbon/react": "^1.60.3",
"lodash": "^4.17.21",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react": "^19.0.0",
"react-dom": "^19.0.0",
"sass": "^1.70.0"
},
"devDependencies": {
"@types/react": "^18.2.48",
"@types/react-dom": "^18.2.18",
"@types/react": "^19.0.0",
"@types/react-dom": "^19.0.0",
"@vitejs/plugin-react": "^4.2.1",
"eslint": "^8.56.0",
"eslint-plugin-react": "^7.33.2",
"eslint-plugin-react-hooks": "^4.6.0",
"eslint-plugin-react-hooks": "^5.1.0",
"eslint-plugin-react-refresh": "^0.4.5",
"vite": "^4.5.3"
},
Expand Down
10 changes: 5 additions & 5 deletions examples/carbon-for-ibm-products/AboutModal/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,17 @@
"@carbon/ibm-products": "^2.21.0",
"@carbon/react": "^1.60.3",
"lodash": "^4.17.21",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react": "^19.0.0",
"react-dom": "^19.0.0",
"sass": "^1.70.0"
},
"devDependencies": {
"@types/react": "^18.2.48",
"@types/react-dom": "^18.2.18",
"@types/react": "^19.0.0",
"@types/react-dom": "^19.0.0",
"@vitejs/plugin-react": "^4.2.1",
"eslint": "^8.56.0",
"eslint-plugin-react": "^7.33.2",
"eslint-plugin-react-hooks": "^4.6.0",
"eslint-plugin-react-hooks": "^5.1.0",
"eslint-plugin-react-refresh": "^0.4.5",
"vite": "^4.5.3"
},
Expand Down
10 changes: 5 additions & 5 deletions examples/carbon-for-ibm-products/BigNumbers/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,17 @@
"@carbon/ibm-products": "^2.21.0",
"@carbon/react": "^1.60.3",
"lodash": "^4.17.21",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react": "^19.0.0",
"react-dom": "^19.0.0",
"sass": "^1.70.0"
},
"devDependencies": {
"@types/react": "^18.2.48",
"@types/react-dom": "^18.2.18",
"@types/react": "^19.0.0",
"@types/react-dom": "^19.0.0",
"@vitejs/plugin-react": "^4.2.1",
"eslint": "^8.56.0",
"eslint-plugin-react": "^7.33.2",
"eslint-plugin-react-hooks": "^4.6.0",
"eslint-plugin-react-hooks": "^5.1.0",
"eslint-plugin-react-refresh": "^0.4.5",
"vite": "^4.5.3"
},
Expand Down
10 changes: 5 additions & 5 deletions examples/carbon-for-ibm-products/Cascade/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,17 @@
"@carbon/ibm-products": "^2.21.0",
"@carbon/react": "^1.60.3",
"lodash": "^4.17.21",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react": "^19.0.0",
"react-dom": "^19.0.0",
"sass": "^1.70.0"
},
"devDependencies": {
"@types/react": "^18.2.48",
"@types/react-dom": "^18.2.18",
"@types/react": "^19.0.0",
"@types/react-dom": "^19.0.0",
"@vitejs/plugin-react": "^4.2.1",
"eslint": "^8.56.0",
"eslint-plugin-react": "^7.33.2",
"eslint-plugin-react-hooks": "^4.6.0",
"eslint-plugin-react-hooks": "^5.1.0",
"eslint-plugin-react-refresh": "^0.4.5",
"vite": "^4.5.3"
},
Expand Down
10 changes: 5 additions & 5 deletions examples/carbon-for-ibm-products/Coachmark/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,17 @@
"@carbon/ibm-products": "^2.21.0",
"@carbon/react": "^1.60.3",
"lodash": "^4.17.21",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react": "^19.0.0",
"react-dom": "^19.0.0",
"sass": "^1.70.0"
},
"devDependencies": {
"@types/react": "^18.2.48",
"@types/react-dom": "^18.2.18",
"@types/react": "^19.0.0",
"@types/react-dom": "^19.0.0",
"@vitejs/plugin-react": "^4.2.1",
"eslint": "^8.56.0",
"eslint-plugin-react": "^7.33.2",
"eslint-plugin-react-hooks": "^4.6.0",
"eslint-plugin-react-hooks": "^5.1.0",
"eslint-plugin-react-refresh": "^0.4.5",
"vite": "^4.5.3"
},
Expand Down
10 changes: 5 additions & 5 deletions examples/carbon-for-ibm-products/CoachmarkBeacon/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,17 @@
"@carbon/ibm-products": "^2.21.0",
"@carbon/react": "^1.60.3",
"lodash": "^4.17.21",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react": "^19.0.0",
"react-dom": "^19.0.0",
"sass": "^1.70.0"
},
"devDependencies": {
"@types/react": "^18.2.48",
"@types/react-dom": "^18.2.18",
"@types/react": "^19.0.0",
"@types/react-dom": "^19.0.0",
"@vitejs/plugin-react": "^4.2.1",
"eslint": "^8.56.0",
"eslint-plugin-react": "^7.33.2",
"eslint-plugin-react-hooks": "^4.6.0",
"eslint-plugin-react-hooks": "^5.1.0",
"eslint-plugin-react-refresh": "^0.4.5",
"vite": "^4.5.3"
},
Expand Down
10 changes: 5 additions & 5 deletions examples/carbon-for-ibm-products/CoachmarkButton/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,17 @@
"@carbon/ibm-products": "^2.21.0",
"@carbon/react": "^1.60.3",
"lodash": "^4.17.21",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react": "^19.0.0",
"react-dom": "^19.0.0",
"sass": "^1.70.0"
},
"devDependencies": {
"@types/react": "^18.2.48",
"@types/react-dom": "^18.2.18",
"@types/react": "^19.0.0",
"@types/react-dom": "^19.0.0",
"@vitejs/plugin-react": "^4.2.1",
"eslint": "^8.56.0",
"eslint-plugin-react": "^7.33.2",
"eslint-plugin-react-hooks": "^4.6.0",
"eslint-plugin-react-hooks": "^5.1.0",
"eslint-plugin-react-refresh": "^0.4.5",
"vite": "^4.5.3"
},
Expand Down
10 changes: 5 additions & 5 deletions examples/carbon-for-ibm-products/CoachmarkFixed/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,17 @@
"@carbon/ibm-products": "^2.21.0",
"@carbon/react": "^1.60.3",
"lodash": "^4.17.21",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react": "^19.0.0",
"react-dom": "^19.0.0",
"sass": "^1.70.0"
},
"devDependencies": {
"@types/react": "^18.2.48",
"@types/react-dom": "^18.2.18",
"@types/react": "^19.0.0",
"@types/react-dom": "^19.0.0",
"@vitejs/plugin-react": "^4.2.1",
"eslint": "^8.56.0",
"eslint-plugin-react": "^7.33.2",
"eslint-plugin-react-hooks": "^4.6.0",
"eslint-plugin-react-hooks": "^5.1.0",
"eslint-plugin-react-refresh": "^0.4.5",
"vite": "^4.5.3"
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,17 @@
"@carbon/ibm-products": "^2.21.0",
"@carbon/react": "^1.60.3",
"lodash": "^4.17.21",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react": "^19.0.0",
"react-dom": "^19.0.0",
"sass": "^1.70.0"
},
"devDependencies": {
"@types/react": "^18.2.48",
"@types/react-dom": "^18.2.18",
"@types/react": "^19.0.0",
"@types/react-dom": "^19.0.0",
"@vitejs/plugin-react": "^4.2.1",
"eslint": "^8.56.0",
"eslint-plugin-react": "^7.33.2",
"eslint-plugin-react-hooks": "^4.6.0",
"eslint-plugin-react-hooks": "^5.1.0",
"eslint-plugin-react-refresh": "^0.4.5",
"vite": "^4.5.3"
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,17 @@
"@carbon/ibm-products": "^2.21.0",
"@carbon/react": "^1.60.3",
"lodash": "^4.17.21",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react": "^19.0.0",
"react-dom": "^19.0.0",
"sass": "^1.70.0"
},
"devDependencies": {
"@types/react": "^18.2.48",
"@types/react-dom": "^18.2.18",
"@types/react": "^19.0.0",
"@types/react-dom": "^19.0.0",
"@vitejs/plugin-react": "^4.2.1",
"eslint": "^8.56.0",
"eslint-plugin-react": "^7.33.2",
"eslint-plugin-react-hooks": "^4.6.0",
"eslint-plugin-react-hooks": "^5.1.0",
"eslint-plugin-react-refresh": "^0.4.5",
"vite": "^4.5.3"
},
Expand Down
10 changes: 5 additions & 5 deletions examples/carbon-for-ibm-products/CoachmarkStack/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,17 @@
"@carbon/ibm-products": "^2.21.0",
"@carbon/react": "^1.60.3",
"lodash": "^4.17.21",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react": "^19.0.0",
"react-dom": "^19.0.0",
"sass": "^1.70.0"
},
"devDependencies": {
"@types/react": "^18.2.48",
"@types/react-dom": "^18.2.18",
"@types/react": "^19.0.0",
"@types/react-dom": "^19.0.0",
"@vitejs/plugin-react": "^4.2.1",
"eslint": "^8.56.0",
"eslint-plugin-react": "^7.33.2",
"eslint-plugin-react-hooks": "^4.6.0",
"eslint-plugin-react-hooks": "^5.1.0",
"eslint-plugin-react-refresh": "^0.4.5",
"vite": "^4.5.3"
},
Expand Down
10 changes: 5 additions & 5 deletions examples/carbon-for-ibm-products/ConditionBuilder/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,17 @@
"@carbon/ibm-products": "^2.21.0",
"@carbon/react": "^1.60.3",
"lodash": "^4.17.21",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react": "^19.0.0",
"react-dom": "^19.0.0",
"sass": "^1.70.0"
},
"devDependencies": {
"@types/react": "^18.2.48",
"@types/react-dom": "^18.2.18",
"@types/react": "^19.0.0",
"@types/react-dom": "^19.0.0",
"@vitejs/plugin-react": "^4.2.1",
"eslint": "^8.56.0",
"eslint-plugin-react": "^7.33.2",
"eslint-plugin-react-hooks": "^4.6.0",
"eslint-plugin-react-hooks": "^5.1.0",
"eslint-plugin-react-refresh": "^0.4.5",
"vite": "^4.5.3"
},
Expand Down
10 changes: 5 additions & 5 deletions examples/carbon-for-ibm-products/CreateFullPage/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,17 @@
"@carbon/ibm-products": "^2.21.0",
"@carbon/react": "^1.60.3",
"lodash": "^4.17.21",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react": "^19.0.0",
"react-dom": "^19.0.0",
"sass": "^1.70.0"
},
"devDependencies": {
"@types/react": "^18.2.48",
"@types/react-dom": "^18.2.18",
"@types/react": "^19.0.0",
"@types/react-dom": "^19.0.0",
"@vitejs/plugin-react": "^4.2.1",
"eslint": "^8.56.0",
"eslint-plugin-react": "^7.33.2",
"eslint-plugin-react-hooks": "^4.6.0",
"eslint-plugin-react-hooks": "^5.1.0",
"eslint-plugin-react-refresh": "^0.4.5",
"vite": "^4.5.3"
},
Expand Down
10 changes: 5 additions & 5 deletions examples/carbon-for-ibm-products/CreateModal/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,17 @@
"@carbon/ibm-products": "^2.21.0",
"@carbon/react": "^1.60.3",
"lodash": "^4.17.21",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react": "^19.0.0",
"react-dom": "^19.0.0",
"sass": "^1.70.0"
},
"devDependencies": {
"@types/react": "^18.2.48",
"@types/react-dom": "^18.2.18",
"@types/react": "^19.0.0",
"@types/react-dom": "^19.0.0",
"@vitejs/plugin-react": "^4.2.1",
"eslint": "^8.56.0",
"eslint-plugin-react": "^7.33.2",
"eslint-plugin-react-hooks": "^4.6.0",
"eslint-plugin-react-hooks": "^5.1.0",
"eslint-plugin-react-refresh": "^0.4.5",
"vite": "^4.5.3"
},
Expand Down
10 changes: 5 additions & 5 deletions examples/carbon-for-ibm-products/CreateSidePanel/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,17 @@
"@carbon/ibm-products": "^2.21.0",
"@carbon/react": "^1.60.3",
"lodash": "^4.17.21",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react": "^19.0.0",
"react-dom": "^19.0.0",
"sass": "^1.70.0"
},
"devDependencies": {
"@types/react": "^18.2.48",
"@types/react-dom": "^18.2.18",
"@types/react": "^19.0.0",
"@types/react-dom": "^19.0.0",
"@vitejs/plugin-react": "^4.2.1",
"eslint": "^8.56.0",
"eslint-plugin-react": "^7.33.2",
"eslint-plugin-react-hooks": "^4.6.0",
"eslint-plugin-react-hooks": "^5.1.0",
"eslint-plugin-react-refresh": "^0.4.5",
"vite": "^4.5.3"
},
Expand Down
Loading
Loading