Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sidePanel): resolve storybook doc page scroll issues #6664

Merged
merged 20 commits into from
Jan 28, 2025

Conversation

makafsal
Copy link
Member

@makafsal makafsal commented Jan 6, 2025

Closes #6623

What did you change?

  1. removed unwanted storybook containers
  2. confirm whether it is storybook or not before setting overflow: hidden for body

How did you test and verify your work?

storybook

@makafsal makafsal requested a review from a team as a code owner January 6, 2025 12:53
@makafsal makafsal requested review from matthewgallo and amal-k-joy and removed request for a team January 6, 2025 12:53
Copy link

netlify bot commented Jan 6, 2025

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit 376c1e7
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/678f3d623a76eb000845a54c
😎 Deploy Preview https://deploy-preview-6664--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 6, 2025

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 376c1e7
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/678f3d62458d280008cf8498
😎 Deploy Preview https://deploy-preview-6664--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.89%. Comparing base (df21099) to head (376c1e7).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6664      +/-   ##
==========================================
- Coverage   80.90%   80.89%   -0.02%     
==========================================
  Files         398      398              
  Lines       12953    12953              
  Branches     4280     4280              
==========================================
- Hits        10480    10478       -2     
- Misses       2473     2475       +2     
Components Coverage Δ
ibm-products ∅ <ø> (∅)
ibm-products-web-components ∅ <ø> (∅)

@makafsal makafsal requested a review from matthewgallo January 7, 2025 07:56
amal-k-joy
amal-k-joy previously approved these changes Jan 7, 2025
Copy link
Contributor

@amal-k-joy amal-k-joy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@matthewgallo matthewgallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The slideIn panel doesn't work as expected with these changes because the element with id ibm-products-page-content was removed.

@amal-k-joy amal-k-joy added this pull request to the merge queue Jan 28, 2025
Merged via the queue into carbon-design-system:main with commit 632d1a3 Jan 28, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SidePanel Storybook Doc]: Storybook doc page scroll issues
3 participants