Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update dev dependencies #6703

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

carbon-automation[bot]
Copy link
Contributor

This PR was automatically generated to update versions of dev dependencies to their latest versions. This helps ensure we get fixes and improvements in a timely fashion and reduces the impact of updating the versions that can arise if versions are allowed to become stale for an extended period.

What did you change?

This action ran yarn upgrade:automatic to update package.json files to request the latest versions of each package. Certain critical packages are intentionally excluded.

This action also deleted the yarn.lock file in order to recreate it with the latest matching versions of secondary dependencies.

This PR includes the various package.json that pull our dependencies forward to the latest versions, the yarn.lock update that maps required versions to the actual versions to be used, and updates the offline mirror.

How did you test and verify your work?

This PR should not normally significantly affect the build outputs or runtime packages. Ensure that yarn ci-check runs cleanly and all tests pass (done automatically as part of the PR checks).

@carbon-automation carbon-automation bot requested a review from a team as a code owner January 15, 2025 04:07
@carbon-automation carbon-automation bot requested review from davidmenendez and amal-k-joy and removed request for a team January 15, 2025 04:07
Copy link

netlify bot commented Jan 15, 2025

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 1e30bb8
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/679bd8ff731ea300085fcae8
😎 Deploy Preview https://deploy-preview-6703--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 15, 2025

Deploy Preview for ibm-products-web-components failed. Why did it fail? →

Name Link
🔨 Latest commit 1e30bb8
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/679bd8ff20cfbf00079b5f35

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 74.10714% with 29 lines in your changes missing coverage. Please review.

Project coverage is 81.28%. Comparing base (d043ffa) to head (1e30bb8).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6703      +/-   ##
==========================================
+ Coverage   81.17%   81.28%   +0.11%     
==========================================
  Files         398      397       -1     
  Lines       12956    12964       +8     
  Branches     4283     4275       -8     
==========================================
+ Hits        10517    10538      +21     
+ Misses       2439     2426      -13     
Components Coverage Δ
ibm-products ∅ <ø> (∅)
ibm-products-web-components ∅ <ø> (∅)

davidmenendez
davidmenendez previously approved these changes Jan 15, 2025
package.json Outdated Show resolved Hide resolved
@davidmenendez
Copy link
Contributor

build failing. i'll take a look 👀

@matthewgallo
Copy link
Member

We're also going to need to import the JSX type from react, based on this, might have to be made in a few places. I did this in a few places for the React 19 PR, I'll try to find the commit for reference.

@matthewgallo
Copy link
Member

698cc9e

@davidmenendez
Copy link
Contributor

this particular update is proving to be quite a difficult one...

@davidmenendez
Copy link
Contributor

everything appears to be working with the exception of the web components tests failing. @matthewgallo any ideas there? the error messaging may indicate that the playwright dependencies may just need to be updated?

Screenshot 2025-01-22 at 1 26 08 PM

@davidmenendez
Copy link
Contributor

AVT tests seem to be failing intermittently for me locally. i think we should address fixing the tests separately in order to get this in.

@@ -127,7 +124,9 @@ const FilterPanel = ({
prevFiltersRef,
});

const shouldReduceMotion = usePrefersReducedMotion();
// NOTE: In the future when we get rid of framer-motion we can use our own usePrefersReducedMotion hook
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@elycheea elycheea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m seeing a FOUT in the Storybook which is what’s triggering the Percy failures. My guess is this line?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants