-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): update dev dependencies #6703
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
❌ Deploy Preview for ibm-products-web-components failed. Why did it fail? →
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6703 +/- ##
==========================================
+ Coverage 81.17% 81.28% +0.11%
==========================================
Files 398 397 -1
Lines 12956 12964 +8
Branches 4283 4275 -8
==========================================
+ Hits 10517 10538 +21
+ Misses 2439 2426 -13
|
build failing. i'll take a look 👀 |
We're also going to need to import the |
this particular update is proving to be quite a difficult one... |
everything appears to be working with the exception of the web components tests failing. @matthewgallo any ideas there? the error messaging may indicate that the playwright dependencies may just need to be updated? |
AVT tests seem to be failing intermittently for me locally. i think we should address fixing the tests separately in order to get this in. |
@@ -127,7 +124,9 @@ const FilterPanel = ({ | |||
prevFiltersRef, | |||
}); | |||
|
|||
const shouldReduceMotion = usePrefersReducedMotion(); | |||
// NOTE: In the future when we get rid of framer-motion we can use our own usePrefersReducedMotion hook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m seeing a FOUT in the Storybook which is what’s triggering the Percy failures. My guess is this line?
This PR was automatically generated to update versions of dev dependencies to their latest versions. This helps ensure we get fixes and improvements in a timely fashion and reduces the impact of updating the versions that can arise if versions are allowed to become stale for an extended period.
What did you change?
This action ran
yarn upgrade:automatic
to updatepackage.json
files to request the latest versions of each package. Certain critical packages are intentionally excluded.This action also deleted the
yarn.lock
file in order to recreate it with the latest matching versions of secondary dependencies.This PR includes the various
package.json
that pull our dependencies forward to the latest versions, theyarn.lock
update that maps required versions to the actual versions to be used, and updates the offline mirror.How did you test and verify your work?
This PR should not normally significantly affect the build outputs or runtime packages. Ensure that
yarn ci-check
runs cleanly and all tests pass (done automatically as part of the PR checks).