Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(custom-element): new es build module #7031

Conversation

ariellalgilmore
Copy link
Member

Closes carbon-design-system/carbon#18761

creates a new es-custom folder which will generate our components with cds-custom- prefix instead of cds-

Changelog

New

  • updated build to add a post build which copies the generates es files and then does a find and replace to swap out all instances of cds with cds-custom
  • add es-custom to gitignore

Testing / Reviewing

run yarn build and see if es-custom folder is generated in web components and if the components have the correct prefix

note

  • User's will need to import two different style files. One with
@use '@carbon/styles' with (
  $prefix: 'cds-custom' // Default prefix
);

and the other will be just

@use '@carbon/styles' 
  • Also, they need to set in their tsconfig files if using an angular version before angular 19 to
"skipLibCheck": true

Copy link

netlify bot commented Mar 4, 2025

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit 5c2aae9
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/67c77a244171cd00080bd2f7
😎 Deploy Preview https://deploy-preview-7031--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 4, 2025

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 5c2aae9
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/67c77a240590110008a63bde
😎 Deploy Preview https://deploy-preview-7031--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.70%. Comparing base (73a0d2f) to head (5c2aae9).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7031      +/-   ##
==========================================
- Coverage   81.73%   81.70%   -0.03%     
==========================================
  Files         401      401              
  Lines       13022    13022              
  Branches     4289     4289              
==========================================
- Hits        10643    10640       -3     
- Misses       2379     2382       +3     
Components Coverage Δ
ibm-products ∅ <ø> (∅)
ibm-products-web-components ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Web Components]: IBM Products - generate new build output with custom prefix
2 participants