fix: implemented default return of the latest block for /block endpoi…

…nt. (#248)

* fix: implemented default return of the latest block for /block endpoint. This will return the latest block if no block identifier was provided.

* fix: implemented default return of the latest block for /block endpoint. This will return the latest block if no block identifier was provided.

* chore: added test

api/src/main/java/org/cardanofoundation/rosetta/api/block/service/LedgerBlockServiceImpl.java

@@ -71,14 +71,16 @@ public class LedgerBlockServiceImpl implements LedgerBlockService {
   @Override
   public Optional<Block> findBlock(Long blockNumber, String blockHash) {
     log.debug("Query blockNumber: {} , blockHash: {}", blockNumber, blockHash);
-    if (blockHash == null && blockNumber != null) {
-      return blockRepository.findByNumber(blockNumber).map(this::toModelFrom);
-    } else if (blockHash != null && blockNumber == null) {
+    if (blockHash != null && blockNumber == null) {
       return blockRepository.findByHash(blockHash).map(this::toModelFrom);
-    } else {
+    } else if (blockHash == null && blockNumber != null) {
+      return blockRepository.findByNumber(blockNumber).map(this::toModelFrom);
+    } else if (blockHash != null && blockNumber != null) {
       return blockRepository
           .findByNumberAndHash(blockNumber, blockHash)
           .map(this::toModelFrom);
+    } else {
+      return blockRepository.findLatestBlock().map(this::toModelFrom);
     }
   }
 

api/src/test/java/org/cardanofoundation/rosetta/api/block/service/LedgerBlockServiceImplIntTest.java

@@ -107,6 +107,15 @@ void findBlockIdentifier_Test_OK_null_blk() {
     assertBlockIdentifierAndTx(block, tx);
   }
 
+  @Test
+  void findBlock_Test_OK_null() {
+    //given
+    //when
+    Optional<Block> block = ledgerBlockService.findBlock(null, null);
+    //then
+    assertThat(block).isPresent();
+  }
+
   @Test
   void findBlock_Test_OK_empty() {
     //given