-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Factor out guards into helpers in balanceTransaction #3092
Conversation
-- Coin selection does not support pre-defining collateral. In Sep 2021 | ||
-- consensus was that we /could/ allow for it with just a day's work or so, | ||
-- but that the need for it was unclear enough that it was not in any way | ||
-- a priority. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might be wrong, but suspect it would not just be "a day's work" 😄 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😄 I thought that was what you said
Thanks! |
3092: Factor out guards into helpers in balanceTransaction r=Anviking a=Anviking - [x] Factor out guards in balanceTransaction into helpers for readability ### Comments Preparation for other work. ### Issue Number ADP-1372 Co-authored-by: Johannes Lund <[email protected]>
Build failed:
#3123 - only three failures, but could be related |
bors r+ |
3092: Factor out guards into helpers in balanceTransaction r=Anviking a=Anviking - [x] Factor out guards in balanceTransaction into helpers for readability ### Comments Preparation for other work. ### Issue Number ADP-1372 Co-authored-by: Johannes Lund <[email protected]>
Build failed: Hydra unit timeout on linux (not mac where we had problems in the past). Last logs:
|
bors r+ |
3092: Factor out guards into helpers in balanceTransaction r=Anviking a=Anviking - [x] Factor out guards in balanceTransaction into helpers for readability ### Comments Preparation for other work. ### Issue Number ADP-1372 Co-authored-by: Johannes Lund <[email protected]>
Build failed:
Apparently a Mac unit test timeout after the tests completed. |
bors r+ |
3092: Factor out guards into helpers in balanceTransaction r=Anviking a=Anviking - [x] Factor out guards in balanceTransaction into helpers for readability ### Comments Preparation for other work. ### Issue Number ADP-1372 Co-authored-by: Johannes Lund <[email protected]>
Build failed:
|
bors r+ |
3092: Factor out guards into helpers in balanceTransaction r=Anviking a=Anviking - [x] Factor out guards in balanceTransaction into helpers for readability ### Comments Preparation for other work. ### Issue Number ADP-1372 Co-authored-by: Johannes Lund <[email protected]>
Build failed:
A lot of stake pool related tests were failing, indicating something ended up wrong with the setup of one pool (have not looked close) |
Bors r+ |
Build succeeded: |
Comments
Preparation for other work.
Issue Number
ADP-1372