-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Write.Tx.BalanceSpec
default to running in all recent eras
#4762
base: master
Are you sure you want to change the base?
Conversation
221fb21
to
71ded94
Compare
Is still relevant? |
This should be done. I've created #4882 for proper scheduling. Closing this PR for now. |
29a64aa
to
55a56fe
Compare
3.850000,0.170121,0.170121 | ||
3.900000,0.170121,0.170121 | ||
3.950000,0.170121,0.170121 | ||
4.000000,0.170121,0.170121 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marginally more expensive than in babbage: 0.169857 — looks right.
A con with separating the goldens by era like this is that we won't ever get GH diffs between eras. Not unless we add latest/pingPong_1
separately from conway/pingPong_1
and babbage/pingPong_1
, which I concidered but didn't end up doing now.
lib/balance-tx/test/spec/Internal/Cardano/Write/Tx/BalanceSpec.hs
Outdated
Show resolved
Hide resolved
lib/balance-tx/test/spec/Internal/Cardano/Write/Tx/BalanceSpec.hs
Outdated
Show resolved
Hide resolved
0524888
to
d9843e4
Compare
Write.Tx.BalanceSpec
tests to ConwayWrite.Tx.BalanceSpec
tests to run in all recent eras
Write.Tx.BalanceSpec
tests to run in all recent erasWrite.Tx.BalanceSpec
default to running in all recent eras
BalanceSpec
tests in all recent eras (forall era. IsRecentEra => RecentEra era
) per default.We now have
We also now have goldens for each era; one in a
babbage
directory, and one in aconway
directory.Fixes #4882