Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Write.Tx.BalanceSpec default to running in all recent eras #4762

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Anviking
Copy link
Member

@Anviking Anviking commented Aug 31, 2024

  • Run BalanceSpec tests in all recent eras (forall era. IsRecentEra => RecentEra era) per default.

We now have

spec :: Spec
spec = do
    forAllRecentEras $ \era -> do
        spec_balanceTx era
        spec_updateTx era

    -- The exact test expectations depend on the test data which was generated
    -- in either Alonzo or Babbage. Only running in Babbage should be fine for
    -- now. When Babbage is dropped we could regenerate the test txs.
    spec_estimateSignedTxSize RecentEraBabbage

We also now have goldens for each era; one in a babbage directory, and one in a conway directory.

Fixes #4882

@Anviking Anviking self-assigned this Aug 31, 2024
@Anviking Anviking force-pushed the anviking/ADP-3413/balanceTx-unit-conway branch from 221fb21 to 71ded94 Compare August 31, 2024 17:45
@abailly
Copy link
Collaborator

abailly commented Dec 11, 2024

Is still relevant?

@Anviking
Copy link
Member Author

This should be done. I've created #4882 for proper scheduling. Closing this PR for now.

@Anviking Anviking closed this Dec 12, 2024
@Anviking Anviking reopened this Jan 7, 2025
@Anviking Anviking force-pushed the anviking/ADP-3413/balanceTx-unit-conway branch 3 times, most recently from 29a64aa to 55a56fe Compare January 10, 2025 16:40
@Anviking Anviking marked this pull request as ready for review January 10, 2025 17:05
3.850000,0.170121,0.170121
3.900000,0.170121,0.170121
3.950000,0.170121,0.170121
4.000000,0.170121,0.170121
Copy link
Member Author

@Anviking Anviking Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marginally more expensive than in babbage: 0.169857 — looks right.

A con with separating the goldens by era like this is that we won't ever get GH diffs between eras. Not unless we add latest/pingPong_1 separately from conway/pingPong_1 and babbage/pingPong_1, which I concidered but didn't end up doing now.

@Anviking Anviking force-pushed the anviking/ADP-3413/balanceTx-unit-conway branch from 0524888 to d9843e4 Compare January 13, 2025 11:37
@Anviking Anviking changed the title Move many Write.Tx.BalanceSpec tests to Conway Move nearly all of Write.Tx.BalanceSpec tests to run in all recent eras Jan 13, 2025
@Anviking Anviking changed the title Move nearly all of Write.Tx.BalanceSpec tests to run in all recent eras Make Write.Tx.BalanceSpec default to running in all recent eras Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update remaining balanceTx unit and property tests to Conway
2 participants