Update changes for next Sanchonet release 8.11.0 #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sotatek-HuyLe3a
force-pushed
the
issue_194
branch
2 times, most recently
from
0711a8b to
fa2e95e
Compare
satran004
reviewed
May 21, 2024
| return stakeDeregistration.getStakeCredential().getHash(); | ||
| } | ||
|
|
||
| AuthCommitteeHotCert authCommitteeHotCert = (AuthCommitteeHotCert) certificate; |
There was a problem hiding this comment.
Should we add a check for cert type here ?
| @@ -20,7 +20,8 @@ public class GenesisData { | |||
| List<Tx> txs; | |||
| List<TxOut> txOuts; | |||
| List<SlotLeader> slotLeaders; | |||
| CostModel costModel; | |||
| CostModel alonzoCostModel; | |||
| CostModel conwayCostModel; | |||
There was a problem hiding this comment.
Do you need to keep costModel in two separate fields or just keep one as both values are merged to get the final cost model ?
satran004
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#194