remove demo field

cardstack · Dec 31, 2024 · a76e895 · a76e895
1 parent eeed06e
commit a76e895
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 149 deletions.
diff --git a/packages/base/catalog-entry.gts b/packages/base/catalog-entry.gts
@@ -3,7 +3,6 @@ import {
   field,
   Component,
   CardDef,
-  FieldDef,
   relativeTo,
   realmInfo,
   linksToMany,
@@ -33,18 +32,13 @@ export class CatalogEntry extends CardDef {
       return new URL(this.ref.module, this[relativeTo]).href;
     },
   });
-  @field demo = contains(FieldDef);
   @field realmName = contains(StringField, {
     computeVia: function (this: CatalogEntry) {
       return this[realmInfo]?.name;
     },
   });
   @field examples = linksToMany(CardDef);
 
-  get showDemo() {
-    return !this.isField;
-  }
-
   static fitted = class Fitted extends Component<typeof this> {
     <template>
       <header class='title'>

diff --git a/packages/experiments-realm/CatalogEntry/1.json b/packages/experiments-realm/CatalogEntry/1.json
@@ -10,13 +10,6 @@
         "name": "Person"
       }
     },
-    "relationships": {
-      "demo.pet": {
-        "links": {
-          "self": "../Pet/1"
-        }
-      }
-    },
     "meta": {
       "adoptsFrom": {
         "module": "https://cardstack.com/base/catalog-entry",

diff --git a/packages/host/tests/acceptance/code-submode/create-file-test.gts b/packages/host/tests/acceptance/code-submode/create-file-test.gts
@@ -94,9 +94,6 @@ const files: Record<string, any> = {
           module: '../error',
           name: 'default',
         },
-        demo: {
-          title: 'Error title',
-        },
       },
       meta: {
         adoptsFrom: {

diff --git a/packages/host/tests/integration/realm-indexing-and-querying-test.gts b/packages/host/tests/integration/realm-indexing-and-querying-test.gts
@@ -649,12 +649,14 @@ module(`Integration | realm indexing and querying`, function (hooks) {
           description: 'Catalog entry for Person card',
           moduleHref: `${testRealmURL}person`,
           realmName: 'Unnamed Workspace',
+          thumbnailURL: null,
+          readMe: null,
+
           isField: false,
           ref: {
             module: `./person`,
             name: 'Person',
           },
-          demo: {},
         },
         meta: {
           adoptsFrom: {
@@ -676,7 +678,6 @@ module(`Integration | realm indexing and querying`, function (hooks) {
       );
       assert.deepEqual(instance?.searchDoc, {
         _cardType: 'Catalog Entry',
-        demo: {},
         description: 'Catalog entry for Person card',
         id: `${testRealmURL}person-catalog-entry`,
         isField: false,
@@ -1589,7 +1590,6 @@ module(`Integration | realm indexing and querying`, function (hooks) {
       },
     );
     if (vendor?.type === 'doc') {
-      console.log(vendor.doc);
       assert.deepEqual(vendor.doc, {
         data: {
           id: `${testRealmURL}Vendor/vendor1`,
@@ -1996,24 +1996,8 @@ module(`Integration | realm indexing and querying`, function (hooks) {
                 module: 'http://localhost:4202/test/booking',
                 name: 'Booking',
               },
-              demo: {
-                title: null,
-                venue: null,
-                startTime: null,
-                endTime: null,
-                hosts: [],
-                sponsors: [],
-              },
             },
             meta: {
-              fields: {
-                demo: {
-                  adoptsFrom: {
-                    module: '../booking',
-                    name: 'Booking',
-                  },
-                },
-              },
               adoptsFrom: {
                 module: 'https://cardstack.com/base/catalog-entry',
                 name: 'CatalogEntry',
@@ -2030,12 +2014,6 @@ module(`Integration | realm indexing and querying`, function (hooks) {
     assert.deepEqual(entry?.searchDoc, {
       _cardType: 'Catalog Entry',
       id: `${testRealmURL}CatalogEntry/booking`,
-      demo: {
-        hosts: null,
-        sponsors: null,
-        title: null,
-        venue: null,
-      },
       description: 'Catalog entry for Booking',
       isField: false,
       moduleHref: 'http://localhost:4202/test/booking',
@@ -2352,25 +2330,9 @@ module(`Integration | realm indexing and querying`, function (hooks) {
                 module: `${testModuleRealm}pet-person`,
                 name: 'PetPerson',
               },
-              demo: { firstName: 'Hassan' },
-            },
-            relationships: {
-              'demo.pets.0': {
-                links: { self: `${testRealmURL}Pet/mango` },
-              },
-              'demo.pets.1': {
-                links: { self: `${testRealmURL}Pet/vanGogh` },
-              },
             },
+            relationships: {},
             meta: {
-              fields: {
-                demo: {
-                  adoptsFrom: {
-                    module: `${testModuleRealm}pet-person`,
-                    name: 'PetPersonField',
-                  },
-                },
-              },
               adoptsFrom: {
                 module: 'https://cardstack.com/base/catalog-entry',
                 name: 'CatalogEntry',
@@ -2406,39 +2368,21 @@ module(`Integration | realm indexing and querying`, function (hooks) {
         attributes: {
           title: 'PetPerson',
           description: 'Catalog entry for PetPerson',
+          readMe: null,
+          thumbnailURL: null,
           ref: {
             module: `${testModuleRealm}pet-person`,
             name: 'PetPerson',
           },
-          demo: { firstName: 'Hassan' },
           isField: false,
           moduleHref: `${testModuleRealm}pet-person`,
           realmName: 'Unnamed Workspace',
         },
-        relationships: {
-          'demo.friend': { links: { self: null } },
-          'demo.pets.0': {
-            links: { self: `${testRealmURL}Pet/mango` },
-            data: { id: `${testRealmURL}Pet/mango`, type: 'card' },
-          },
-          'demo.pets.1': {
-            links: { self: `${testRealmURL}Pet/vanGogh` },
-            data: { id: `${testRealmURL}Pet/vanGogh`, type: 'card' },
-          },
-        },
         meta: {
           adoptsFrom: {
             module: 'https://cardstack.com/base/catalog-entry',
             name: 'CatalogEntry',
           },
-          fields: {
-            demo: {
-              adoptsFrom: {
-                module: `${testModuleRealm}pet-person`,
-                name: 'PetPersonField',
-              },
-            },
-          },
           lastModified: adapter.lastModifiedMap.get(
             `${testRealmURL}pet-person-catalog-entry.json`,
           ),
@@ -2449,55 +2393,6 @@ module(`Integration | realm indexing and querying`, function (hooks) {
           ),
         },
       });
-
-      assert.deepEqual(catalogEntry.doc.included, [
-        {
-          id: `${testRealmURL}Pet/mango`,
-          type: 'card',
-          links: { self: `${testRealmURL}Pet/mango` },
-          attributes: {
-            description: null,
-            firstName: 'Mango',
-            title: 'Mango',
-            thumbnailURL: null,
-          },
-          relationships: { owner: { links: { self: null } } },
-          meta: {
-            adoptsFrom: { module: `${testModuleRealm}pet`, name: 'Pet' },
-            lastModified: adapter.lastModifiedMap.get(
-              `${testRealmURL}Pet/mango.json`,
-            ),
-            realmInfo: testRealmInfo,
-            realmURL: 'http://test-realm/test/',
-            resourceCreatedAt: adapter.resourceCreatedAtMap.get(
-              `${testRealmURL}pet-person-catalog-entry.json`,
-            ),
-          },
-        },
-        {
-          id: `${testRealmURL}Pet/vanGogh`,
-          type: 'card',
-          links: { self: `${testRealmURL}Pet/vanGogh` },
-          attributes: {
-            description: null,
-            firstName: 'Van Gogh',
-            title: 'Van Gogh',
-            thumbnailURL: null,
-          },
-          relationships: { owner: { links: { self: null } } },
-          meta: {
-            adoptsFrom: { module: `${testModuleRealm}pet`, name: 'Pet' },
-            lastModified: adapter.lastModifiedMap.get(
-              `${testRealmURL}Pet/vanGogh.json`,
-            ),
-            realmInfo: testRealmInfo,
-            realmURL: 'http://test-realm/test/',
-            resourceCreatedAt: adapter.resourceCreatedAtMap.get(
-              `${testRealmURL}pet-person-catalog-entry.json`,
-            ),
-          },
-        },
-      ]);
     } else {
       assert.ok(
         false,
@@ -2516,28 +2411,6 @@ module(`Integration | realm indexing and querying`, function (hooks) {
         title: 'PetPerson',
         description: 'Catalog entry for PetPerson',
         ref: `${testModuleRealm}pet-person/PetPerson`,
-        demo: {
-          firstName: 'Hassan',
-          pets: [
-            {
-              id: `${testRealmURL}Pet/mango`,
-              description: null,
-              firstName: 'Mango',
-              owner: null,
-              title: 'Mango',
-              thumbnailURL: null,
-            },
-            {
-              id: `${testRealmURL}Pet/vanGogh`,
-              description: null,
-              firstName: 'Van Gogh',
-              owner: null,
-              title: 'Van Gogh',
-              thumbnailURL: null,
-            },
-          ],
-          friend: null,
-        },
         isField: false,
         moduleHref: `${testModuleRealm}pet-person`,
         realmName: 'Unnamed Workspace',