removing async computed from tests

cardstack · May 16, 2024 · fec5e23 · fec5e23
1 parent 991f0cc
commit fec5e23
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 419 deletions.
diff --git a/docs/computed-fields.md b/docs/computed-fields.md
@@ -37,28 +37,6 @@ When any field consumed by the computed field changes, the value will [rerender]
 
 Computed fields are eagerly evaluated, they do not need to be consumed for `computeVia` to run.
 
-## Async computation
-
-The calculation can be async:
-
-```typescript
-@field slowName = contains(StringCard, {
-  computeVia: async function () {
-    await new Promise((resolve) => setTimeout(resolve, 10));
-    return this.firstName;
-  }
-});
-```
-
-The values of async computed fields are available synchronously in other `computedVia` functions. Since async field values are not guaranteed to be present, you can use card API [`getIfReady`](https://github.com/cardstack/boxel/blob/307d78676ebdb93cee75d61b8812914013a094a7/packages/base/card-api.gts#L2112) avoid errors about the field not being ready:
-
-```javascript
-await getIfReady(this, 'fullName');
-// 'Carl Stack'
-await getIfReady(this, 'fullName');
-// {type: 'not-ready', fieldName: 'fullName', instance: …}
-```
-
 ## Computed `linksTo` and `linksToMany`
 
 While `computeVia` can currently only be applied to `contains`/`containsMany` fields, there’s a plan to let it work for `linksTo` and `linksToMany` in the future.
diff --git a/packages/host/app/services/render-service.ts b/packages/host/app/services/render-service.ts
@@ -123,6 +123,7 @@ export default class RenderService extends Service {
     return parseCardHtml(html);
   }
 
+  // TODO delete me
   private async resolveField(
     params: Omit<RenderCardParams, 'format'> & { fieldName: string },
   ): Promise<void> {

diff --git a/packages/host/tests/cards/person.gts b/packages/host/tests/cards/person.gts
@@ -14,8 +14,7 @@ export class Person extends CardDef {
   @field email = contains(StringCard);
   @field posts = contains(NumberCard);
   @field fullName = contains(StringCard, {
-    computeVia: async function (this: Person) {
-      await new Promise((resolve) => setTimeout(resolve, 10));
+    computeVia: function (this: Person) {
       return `${this.firstName ?? ''} ${this.lastName ?? ''}`;
     },
   });
@@ -46,8 +45,7 @@ export class PersonField extends FieldDef {
   @field email = contains(StringCard);
   @field posts = contains(NumberCard);
   @field fullName = contains(StringCard, {
-    computeVia: async function (this: Person) {
-      await new Promise((resolve) => setTimeout(resolve, 10));
+    computeVia: function (this: Person) {
       return `${this.firstName ?? ''} ${this.lastName ?? ''}`;
     },
   });