-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: Add deployments #1109
ui: Add deployments #1109
Conversation
for now?
It hasn’t been built!
Test Results538 tests ±0 534 ✔️ ±0 8m 14s ⏱️ +8s Results for commit 5edc4bb. ± Comparison against base commit 94d0beb. This pull request removes 538 and adds 538 tests. Note that renamed tests count towards both.
This pull request removes 4 skipped tests and adds 4 skipped tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know the syntax well enough to review this but thanks for working on this. It'll be very helpful
This mirrors #1109 for boxel-motion.
This lets
packages/boxel-ui/test-app
be deployed to staging, which makes it easy to compare against a reference implementation when things seem wrong.It also creates a PR preview deployment when
boxel-ui
has changed so you don’t have to run locally when reviewing.There are only staging deployments because there’s really no difference between the two environments for this package.