Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Add deployments #1109

Merged
merged 27 commits into from
Mar 26, 2024
Merged

ui: Add deployments #1109

merged 27 commits into from
Mar 26, 2024

Conversation

backspace
Copy link
Contributor

@backspace backspace commented Mar 21, 2024

This lets packages/boxel-ui/test-app be deployed to staging, which makes it easy to compare against a reference implementation when things seem wrong.

It also creates a PR preview deployment when boxel-ui has changed so you don’t have to run locally when reviewing.

There are only staging deployments because there’s really no difference between the two environments for this package.

@backspace backspace added the enhancement New feature or request label Mar 21, 2024
@backspace backspace self-assigned this Mar 21, 2024
Copy link

github-actions bot commented Mar 21, 2024

Test Results

538 tests  ±0   534 ✔️ ±0   8m 14s ⏱️ +8s
    1 suites ±0       4 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit 5edc4bb. ± Comparison against base commit 94d0beb.

This pull request removes 538 and adds 538 tests. Note that renamed tests count towards both.
Chrome 123.0 ‑ Acceptance | Freestyle: smoke check
Chrome 123.0 ‑ Acceptance | basic tests: glimmer-scoped-css smoke test
Chrome 123.0 ‑ Acceptance | basic tests: visiting realm root
Chrome 123.0 ‑ Acceptance | code submode tests: Clicking card in search panel opens card JSON in editor
Chrome 123.0 ‑ Acceptance | code submode tests: can handle error when user puts unidentified domain in card URL bar
Chrome 123.0 ‑ Acceptance | code submode tests: card preview live updates when index changes
Chrome 123.0 ‑ Acceptance | code submode tests: card preview will show in the 3rd column when submode is set to code
Chrome 123.0 ‑ Acceptance | code submode tests: card-catalog does not offer to "create new card" when editing linked fields in code mode
Chrome 123.0 ‑ Acceptance | code submode tests: changes cursor position when selected module declaration is changed
Chrome 123.0 ‑ Acceptance | code submode tests: changes selected module declaration when cursor position is changed
…
Chrome 122.0 ‑ Acceptance | Freestyle: smoke check
Chrome 122.0 ‑ Acceptance | basic tests: glimmer-scoped-css smoke test
Chrome 122.0 ‑ Acceptance | basic tests: visiting realm root
Chrome 122.0 ‑ Acceptance | code submode tests: Clicking card in search panel opens card JSON in editor
Chrome 122.0 ‑ Acceptance | code submode tests: can handle error when user puts unidentified domain in card URL bar
Chrome 122.0 ‑ Acceptance | code submode tests: card preview live updates when index changes
Chrome 122.0 ‑ Acceptance | code submode tests: card preview will show in the 3rd column when submode is set to code
Chrome 122.0 ‑ Acceptance | code submode tests: card-catalog does not offer to "create new card" when editing linked fields in code mode
Chrome 122.0 ‑ Acceptance | code submode tests: changes cursor position when selected module declaration is changed
Chrome 122.0 ‑ Acceptance | code submode tests: changes selected module declaration when cursor position is changed
…
This pull request removes 4 skipped tests and adds 4 skipped tests. Note that renamed tests count towards both.
Chrome 123.0 ‑ Integration | card-editor: can create a specialized a new card to populate a linksTo field
Chrome 123.0 ‑ Integration | operator-mode: can create a specialized a new card to populate a linksTo field
Chrome 123.0 ‑ Integration | operator-mode: can create a specialized a new card to populate a linksToMany field
Chrome 123.0 ‑ Integration | search-index > query: can filter on an array of primitive fields inside a containsMany using 'eq'
Chrome 122.0 ‑ Integration | card-editor: can create a specialized a new card to populate a linksTo field
Chrome 122.0 ‑ Integration | operator-mode: can create a specialized a new card to populate a linksTo field
Chrome 122.0 ‑ Integration | operator-mode: can create a specialized a new card to populate a linksToMany field
Chrome 122.0 ‑ Integration | search-index > query: can filter on an array of primitive fields inside a containsMany using 'eq'

♻️ This comment has been updated with latest results.

@backspace backspace marked this pull request as ready for review March 21, 2024 22:52
@backspace backspace requested a review from a team March 21, 2024 22:52
Copy link
Contributor

@burieberry burieberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know the syntax well enough to review this but thanks for working on this. It'll be very helpful

@backspace backspace merged commit 2acaf3e into main Mar 26, 2024
22 checks passed
@delete-merged-branch delete-merged-branch bot deleted the ui/deploy-cs-6634 branch March 26, 2024 21:16
backspace added a commit that referenced this pull request Mar 27, 2024
This mirrors #1109 for boxel-motion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants