Save command-result card to workspace #1647
Conversation
|
I sometimes see results not appearing. I thought this was actually fixed before.. is it your experience to see this often? |
|
So we copy the result card to the workspace but not the cards itself. The result card will just linksToMany back to wherever the cards come from? |
Are you talking about CS-7255? I only saw that happen on prod. I haven't checked recently on prod. |
Yes, the idea is that any card shared in chat can be copied to workspace the same way. In the isolated search results card, the results are clickable. |
Hmm, I'll take a look what we can do there. |
packages/base/command.gts
Outdated
| @field toolCallId = contains(StringField); | ||
| @field name = contains(StringField); | ||
| @field payload = contains(CommandObjectField); //arguments of toolCall. Its not called arguments due to lint | ||
| @field payload = contains(ToolCallArg); //arguments of toolCall. Its not called arguments due to lint |
There was a problem hiding this comment.
I think we prefer this to be more abstract than "ToolCallArg". That phrase is AI Bot specific as far as I understand it, and not all commands should interact with AI.
There was a problem hiding this comment.
is CommandObjectField a better name then? I also considered converting it to a string and parsing as needed.
| // @ts-ignore "cardContext is declared but not used" | ||
| private get cardContext() { | ||
| return { | ||
| actions: this.publicAPI(this, this.stacks[0]?.length ? 1 : 0), |
There was a problem hiding this comment.
I know that targeting the right column is the correct default for the copy command, but is it really the correct default for all actions?
| if (opts?.isWritableRealm) { | ||
| let url = card?.[api.realmURL]; | ||
| if (url && this.realm.canWrite(url.href)) { | ||
| return url; | ||
| } | ||
| if (!this.realm.defaultWritableRealm) { | ||
| throw new Error('Could not find a writable realm'); | ||
| } | ||
| return new URL(this.realm.defaultWritableRealm.path); | ||
| } | ||
| // in the case where we get no realm URL from the card, we are dealing with | ||
| // a new card instance that does not have a realm URL yet. | ||
| return card[api.realmURL] ?? new URL(this.realm.defaultReadableRealm.path); |
There was a problem hiding this comment.
I see that this PR is extending the existing fallback behavior. But this fallback behavior doesn't belong here.
getRealmURL should only return a card's actual realm url. When there isn't one, it should return undefined, and it should be up to the caller to pick a default instead.
Opened the menu with the button again after copy for the screenshot:
copyCardaction in interact submode (because the logic for checking the realm of any open card in stack required this to live there)@providepattern)isWritableRealm) togetRealmURLfunction incardServicefor it to return a writable realm url. By default it returns a readable realm url.Copy to Workspace, then we save a copy of the CommandResult card in user's workspace.Note: