Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement pieces of planned Commands API in support of AI App Generator card #1746

Merged
merged 48 commits into from
Nov 19, 2024

Conversation

lukemelia
Copy link
Contributor

@lukemelia lukemelia commented Oct 31, 2024

This PR does not include the finished vision for the Commands API, but it is a helpful merge point.

Still to-do in future PRS:

  • get module creation working smoothly via commands
  • sample data generation via commands
  • Use loader to access host commands via import instead of loadCommand API
  • Add tools to chat as roomState similar to how we treat Skills and attached Cards
  • Update system prompt to make sure ai knows which tools are auto-executable and which are not

Copy link

github-actions bot commented Oct 31, 2024

Host Test Results

    1 files  ±0      1 suites  ±0   19m 31s ⏱️ -44s
683 tests +3  682 ✔️ +3  1 💤 ±0  0 ±0 
688 runs  +3  687 ✔️ +3  1 💤 ±0  0 ±0 

Results for commit 5cf45e7. ± Comparison against base commit 5172301.

This pull request removes 1 and adds 4 tests. Note that renamed tests count towards both.
Chrome 131.0 ‑ Integration | ai-assistant-panel: it only applies changes from the chat if the stack contains a card with that ID
Chrome 131.0 ‑ Acceptance | Commands tests: a command sent via sendAiAssistantMessage with autoExecute flag is automatically executed by the bot
Chrome 131.0 ‑ Acceptance | Commands tests: a command sent via sendAiAssistantMessage without autoExecute flag is not automatically executed by the bot
Chrome 131.0 ‑ Acceptance | Commands tests: a scripted command can create a card, update it and show it
Chrome 131.0 ‑ Integration | commands | switch-submode: switch to code submode

♻️ This comment has been updated with latest results.

lukemelia and others added 28 commits November 4, 2024 14:32
…k/boxel into cs-7389-introduce-command-types
@lukemelia lukemelia marked this pull request as ready for review November 14, 2024 21:53
packages/ai-bot/main.ts Outdated Show resolved Hide resolved
@lukemelia lukemelia requested a review from a team November 18, 2024 21:50
packages/base/command.gts Outdated Show resolved Hide resolved
Copy link
Contributor

@habdelra habdelra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor items, but looks fine overall

@lukemelia lukemelia merged commit 5a3db79 into main Nov 19, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants