Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functional search bar to crm layout #1854

Merged
merged 11 commits into from
Dec 3, 2024
Merged

Add functional search bar to crm layout #1854

merged 11 commits into from
Dec 3, 2024

Conversation

tintinthong
Copy link
Contributor

@tintinthong tintinthong commented Nov 28, 2024 •
edited
Loading

Relies on #1853

  • Filters by contact name OR company name
  • switching tab will clear the search
  • made a simple search input component

@tintinthong tintinthong changed the title Add search bar to crm layout Add functional search bar to crm layout Nov 28, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

Host Test Results

    1 files  ±0      1 suites  ±0   19m 43s ⏱️ -42s
690 tests +1  689 ✔️ +1  1 💤 ±0  0 ❌ ±0 
695 runs  +1  694 ✔️ +1  1 💤 ±0  0 ❌ ±0 

Results for commit 71b54c6. ± Comparison against base commit 2c96b3b.

♻️ This comment has been updated with latest results.

@tintinthong
Copy link
Contributor Author

The failing test shud have been fixed in the #1853

@tintinthong
Copy link
Contributor Author

This is blocked now with the discussion of css variables unfortunately.

@tintinthong tintinthong marked this pull request as draft December 2, 2024 14:38
@tintinthong tintinthong marked this pull request as ready for review December 2, 2024 16:42
@tintinthong tintinthong merged commit 91c4420 into main Dec 3, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burieberry burieberry burieberry approved these changes

@lucaslyl lucaslyl Awaiting requested review from lucaslyl

@richardhjtan richardhjtan Awaiting requested review from richardhjtan

Assignees
No one assigned
Labels
boxel-ui experiments-component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tintinthong @burieberry