Author fields & templates; Blog App updates #1867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burieberry
force-pushed
the
cs-7429-author-card
branch
3 times, most recently
from
4741476 to
bb3ada4
Compare
burieberry
commented
Dec 10, 2024
Comment on lines
+343
to
362
| let realmUrl = this.args.model[realmURL]; | ||
| if (!this.args.model.id || !realmUrl?.href) { | ||
| throw new Error(`Missing card id or realm url`); | ||
| } | ||
| let relativeTo = relativeURL( | ||
| new URL(this.args.model.id), | ||
| new URL(`${cardRef.module}/${cardRef.name}`), | ||
| realmUrl, | ||
| ); | ||
| if (!relativeTo) { | ||
| throw new Error(`Missing relative url`); | ||
| } | ||
| filter.query = { | ||
| filter: { | ||
| on: cardRef, | ||
| eq: { 'blog.id': this.args.model.id! }, | ||
| any: [ | ||
| { eq: { 'blog.id': this.args.model.id } }, | ||
| { eq: { 'blog.id': relativeTo } }, | ||
| ], | ||
| }, |
There was a problem hiding this comment.
This is to cover both relative and absolute urls in the linksTo search.
burieberry
force-pushed
the
cs-7429-author-card
branch
from
990876b to
35a584f
Compare
use featured-image field in blog post
burieberry
force-pushed
the
cs-7429-author-card
branch
from
35a584f to
820f5b7
Compare
burieberry
changed the title
richardhjtan
approved these changes
Dec 12, 2024
jurgenwerk
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
FeaturedImageand use in author and blogpost isolated templates (uses image url, has caption/credit fields)isUsedfield property was needed)Isolated Author:
Embedded Author:
One of the fitted views:
