CS 7628 error cards design update #1911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardhjtan
force-pushed
the
CS-7628-error-state-design-update
branch
from
227c185 to
8bf1351
Compare
richardhjtan
force-pushed
the
CS-7628-error-state-design-update
branch
from
8bf1351 to
bd609f2
Compare
habdelra
reviewed
Dec 10, 2024
| @@ -1117,7 +1117,6 @@ export default class CodeSubmode extends Component<Signature> { | |||
| } | |||
|
|
|||
| .card-error { | |||
| flex: 2; | |||
There was a problem hiding this comment.
i added this because of how errors are displayed in the code mode preview such that the error detail accordion when open took up half as much space as the last known good state. double check the view for small screens too to make sure it makes sense at different sizes.
There was a problem hiding this comment.
Thanks for bringing it out @habdelra , then I understand why flex property is introduced now. Code mode container is displaying flex column. I will tweak and check again
|
Can you include some screenshots of what this looks like in code mode too? this error page is shared between interact mode and code mode |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to https://linear.app/cardstack/issue/CS-7628/design-for-errored-cards-states
What is changing
Notes