Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING] Update our custom matrix identifiers from org.boxel to app.boxel #1953

Merged
merged 4 commits into from
Dec 19, 2024

Conversation

lukemelia
Copy link
Contributor

  • Once merged, old messages will not appear and user realms will need to be set again

Copy link

github-actions bot commented Dec 18, 2024

Host Test Results

    1 files  ±0      1 suites  ±0   30m 48s ⏱️ +34s
713 tests ±0  711 ✔️ ±0  2 💤 ±0  0 ±0 
718 runs  ±0  716 ✔️ ±0  2 💤 ±0  0 ±0 

Results for commit c46c43b. ± Comparison against base commit 2f4a798.

♻️ This comment has been updated with latest results.

@lukemelia lukemelia force-pushed the org-boxel-to-app-boxel branch from 6c6ae21 to 21b1641 Compare December 18, 2024 20:13
@lukemelia lukemelia requested a review from IanCal December 18, 2024 20:41
@IanCal
Copy link
Contributor

IanCal commented Dec 18, 2024

I've not had a chance to run this yet, but the changes look good and I like the move to consts.

I wondered if it makes sense to have something to auto migrate realms? Like get the current realms and if they're empty, check the old key and overwrite?

@lukemelia
Copy link
Contributor Author

I wondered if it makes sense to have something to auto migrate realms? Like get the current realms and if they're empty, check the old key and overwrite?

Do you mean realms or rooms?

@IanCal
Copy link
Contributor

IanCal commented Dec 19, 2024

I wondered if it makes sense to have something to auto migrate realms? Like get the current realms and if they're empty, check the old key and overwrite?

Do you mean realms or rooms?

The realms a user has access to, so checking the account data for the new key, if it's not present copying it from the old key to the new one. Migrating the stuff just in the account data.

@IanCal
Copy link
Contributor

IanCal commented Dec 19, 2024

@lukemelia proposed a migration step for the list of realms here: #1959 to smooth over the change.

Copy link
Contributor

@IanCal IanCal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, an import didn't work in the aibot so I changed it to pull from runtime common directly (other option would have been doing a re-export I think). Seems to work fine and I can't find missing updates in the rest of the code.

@lukemelia lukemelia force-pushed the org-boxel-to-app-boxel branch from c5876a6 to c46c43b Compare December 19, 2024 22:27
@lukemelia lukemelia merged commit eda36f6 into main Dec 19, 2024
43 checks passed
@lukemelia lukemelia deleted the org-boxel-to-app-boxel branch December 19, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants