-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BREAKING] Update our custom matrix identifiers from org.boxel to app.boxel #1953
Conversation
lukemelia
commented
Dec 18, 2024
- Once merged, old messages will not appear and user realms will need to be set again
6c6ae21
to
21b1641
Compare
I've not had a chance to run this yet, but the changes look good and I like the move to consts. I wondered if it makes sense to have something to auto migrate realms? Like get the current realms and if they're empty, check the old key and overwrite? |
Do you mean realms or rooms? |
The realms a user has access to, so checking the account data for the new key, if it's not present copying it from the old key to the new one. Migrating the stuff just in the account data. |
@lukemelia proposed a migration step for the list of realms here: #1959 to smooth over the change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, an import didn't work in the aibot so I changed it to pull from runtime common directly (other option would have been doing a re-export I think). Seems to work fine and I can't find missing updates in the rest of the code.
c5876a6
to
c46c43b
Compare