Fix opening animation when closing card #1990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurgenwerk
approved these changes
Dec 27, 2024
lukemelia
approved these changes
Dec 27, 2024
richardhjtan
force-pushed
the
CS-7729-fix-open-animation-when-closing-card
branch
from
420b9ea to
8bcc907
Compare
richardhjtan
force-pushed
the
CS-7729-fix-open-animation-when-closing-card
branch
from
8bcc907 to
49352ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to https://linear.app/cardstack/issue/CS-7729/open-animation-gets-triggered-when-closing-card
What is changing
Before
Screen_Recording_2024-12-23_at_10.08.04_AM.1.mov
After
fix-close-not-trigger-opening.mov