Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing stack-item headerColor and realm-icon border properties #2038

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

burieberry
Copy link
Contributor

Before:
Stack Item's headerColor disappeared after opening and closing another card in the stack on top of it
before

After:
after

@burieberry burieberry requested a review from a team January 13, 2025 22:42
Copy link
Contributor

@lukemelia lukemelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible to get a test to prevent a regression on this?

Copy link

github-actions bot commented Jan 13, 2025

Host Test Results

    1 files  ±0      1 suites  ±0   21m 41s ⏱️ -26s
729 tests +1  727 ✔️ +1  2 💤 ±0  0 ±0 
734 runs  +1  732 ✔️ +1  2 💤 ±0  0 ±0 

Results for commit 5ea628a. ± Comparison against base commit 0b30125.

♻️ This comment has been updated with latest results.

@burieberry burieberry force-pushed the cs-7807-header-color-loss branch from aea8f5e to 6eb849c Compare January 14, 2025 16:00
@burieberry burieberry merged commit 61a1622 into main Jan 14, 2025
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants