Add _queue-status endpoint to realm server #2070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Host Test Results 1 files ± 0 1 suites ±0 22m 50s ⏱️ +55s Results for commit a36644b. ± Comparison against base commit 316d35f. This pull request removes 1 and adds 51 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
backspace
approved these changes
Jan 22, 2025
habdelra
reviewed
Jan 22, 2025
Comment on lines
9
to
33
| return async function (ctxt: Koa.Context, _next: Koa.Next) { | ||
| let [{ pending_job_count }] = (await query(dbAdapter, [ | ||
| `SELECT COUNT(*) as pending_job_count FROM jobs WHERE status='unfulfilled'`, | ||
| ])) as { | ||
| pending_job_count: string; | ||
| }[]; | ||
| return setContextResponse( | ||
| ctxt, | ||
| new Response( | ||
| JSON.stringify({ | ||
| data: { | ||
| type: 'queue-status', | ||
| id: 'queue-status', | ||
| attributes: { | ||
| pending: parseInt(pending_job_count, 10), | ||
| }, | ||
| }, | ||
| }), | ||
| { | ||
| headers: { 'content-type': SupportedMimeType.JSONAPI }, | ||
| }, | ||
| ), | ||
| ); | ||
| }; | ||
| } |
There was a problem hiding this comment.
is it ok that this is an unprotected route? perhaps we should have a shared secret to access this? otherwise a malicious client might try to DDoS our DB impacting the system overall.
There was a problem hiding this comment.
In our previous projects we had a x-data-integrity-checks-authorization header was used to authorize requests of this type. Perhaps we could have something similar here, depending on the service that will consume this
lukemelia
force-pushed
the
queue-depth-endpoint
branch
from
c686323 to
a36644b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.