Add "copy from seed realm" checkbox #2077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FadhlanR
changed the title
habdelra
reviewed
Jan 22, 2025
habdelra
reviewed
Jan 22, 2025
| join(this.seedPath!.replace(/\/$/, ''), 'index.json'), | ||
| join(realmPath!.replace(/\/$/, ''), 'index.json'), | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| let realm = new Realm( |
There was a problem hiding this comment.
you are going to have to also make sure to not set the copiedFromRealm value in the Realm constructor options below (after you merge from upstream) when copyFromSeedRealm is false.
There was a problem hiding this comment.
jurgenwerk
approved these changes
Jan 23, 2025
habdelra
reviewed
Jan 23, 2025
habdelra
approved these changes
Jan 23, 2025
Co-authored-by: Hassan Abdel-Rahman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I added a checkbox to the create workspace form to specify whether to copy files from the seed realm.