Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non tool call models #2089

Merged
merged 3 commits into from
Jan 29, 2025
Merged

Support non tool call models #2089

merged 3 commits into from
Jan 29, 2025

Conversation

IanCal
Copy link
Contributor

@IanCal IanCal commented Jan 26, 2025

This change loads (at boot of the aibot) all models currently on openrouter that support tool calls.

While most parameters are safe to add in for providers that don't support them (they are just ignored) tool calls result in a 404 error.

I've tested swapping from a model that supports tools and using them (e.g. patching) to ones that don't and that seems to be fine.

Note - R1 is currently fairly slow and we don't return the reasoning tokens so the latency can be very high.

Copy link

github-actions bot commented Jan 26, 2025

Host Test Results

    1 files  ±0      1 suites  ±0   22m 21s ⏱️ -29s
742 tests ±0  740 ✔️ ±0  2 💤 ±0  0 ±0 
747 runs  ±0  745 ✔️ ±0  2 💤 ±0  0 ±0 

Results for commit ccf69cf. ± Comparison against base commit 3920809.

♻️ This comment has been updated with latest results.

@jurgenwerk
Copy link
Contributor

jurgenwerk commented Jan 28, 2025

I'm trying this locally and I can't seem to get deepseek working:

image

I'm getting this error: 'missing finish_reason for choice 0' (after several minutes)

@IanCal IanCal merged commit c8731f2 into main Jan 29, 2025
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants