Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename catalog entry to boxel spec #2102

Merged
merged 16 commits into from
Feb 3, 2025
Merged

Rename catalog entry to boxel spec #2102

merged 16 commits into from
Feb 3, 2025

Conversation

tintinthong
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Jan 29, 2025

Host Test Results

    1 files  ±0      1 suites  ±0   22m 48s ⏱️ -34s
747 tests ±0  745 ✔️ ±0  2 💤 ±0  0 ±0 
752 runs  ±0  750 ✔️ ±0  2 💤 ±0  0 ±0 

Results for commit cab540b. ± Comparison against base commit 673215f.

This pull request removes 8 and adds 8 tests. Note that renamed tests count towards both.
Chrome 132.0 ‑ Integration | operator-mode: Choosing a new catalog entry card automatically saves the card with empty values before popping the card onto the stack in "edit" view
Chrome 132.0 ‑ Integration | operator-mode: cancel button closes the catalog-entry card picker
Chrome 132.0 ‑ Integration | operator-mode: displays cards on cards-grid and includes `catalog-entry` instances
Chrome 132.0 ‑ boxel spec preview: have ability to create new boxel spec instances
Chrome 132.0 ‑ boxel spec preview: title does not default to "default"
Chrome 132.0 ‑ boxel spec preview: view when there are multiple boxel spec instances
Chrome 132.0 ‑ boxel spec preview: view when there are no boxel spec instances
Chrome 132.0 ‑ boxel spec preview: view when there is a single boxel spec instance
Chrome 132.0 ‑ Integration | operator-mode: Choosing a new  card automatically saves the card with empty values before popping the card onto the stack in "edit" view
Chrome 132.0 ‑ Integration | operator-mode: cancel button closes the spec card picker
Chrome 132.0 ‑ Integration | operator-mode: displays cards on cards-grid and includes `spec` instances
Chrome 132.0 ‑ Spec preview: have ability to create new spec instances
Chrome 132.0 ‑ Spec preview: title does not default to "default"
Chrome 132.0 ‑ Spec preview: view when there are multiple spec instances
Chrome 132.0 ‑ Spec preview: view when there are no spec instances
Chrome 132.0 ‑ Spec preview: view when there is a single spec instance

♻️ This comment has been updated with latest results.

@tintinthong tintinthong requested a review from a team January 29, 2025 14:44
Copy link
Contributor

@lukemelia lukemelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just call it a "spec" internally? Prefixing with Boxel is not something we do for anything else, and it is all in Boxel.

@tintinthong
Copy link
Contributor Author

tintinthong commented Jan 29, 2025

Should we just call it a "spec" internally? Prefixing with Boxel is not something we do for anything else, and it is all in Boxel.

internally? Do you mean have a distinction between the way we name it in the UI vs code?

An alternative is to change Boxel Spec -> Code Spec which was what Chris used to call it last time.

I am ok with these options

  • Option 1: Call it "Spec" in the ui and code
  • Option 2: Call it "Code Spec" in the ui and code
  • Option 3: Call it "Boxel Spec" in the ui (wherever design shows) and code refer to it as "Spec"

@tintinthong tintinthong merged commit 318ca38 into main Feb 3, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants