Move SSE to Matrix #2116
Draft
Move SSE to Matrix #2116
+2,256
−2,558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Host Test Results 1 files ±0 1 suites ±0 24m 47s ⏱️ +17s Results for commit f4b083f. ± Comparison against base commit 0c08ab6. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
backspace
force-pushed
the
matrix-sse-cs-7916
branch
from
2288094 to
b2d57db
Compare
backspace
force-pushed
the
matrix-sse-cs-7916
branch
from
b2d57db to
7cd9d2c
Compare
The adapter seems like the place but some interface changes will be needed to make it work cross-environment.
This probably needs to move into another hook…? Or should test realm setup hooks error if it hasn’t been called?
It’s probably at the point that I should stop changing tests to add this setup and make it built-in…???
This was causing the count to be off, the original didn’t have an assertion, just an error.
I hate it??? But what is to be done.
# Conflicts: # packages/host/tests/acceptance/code-submode/playground-test.gts
# Conflicts: # packages/host/tests/acceptance/code-submode/playground-test.gts
Is this the right place? hmm
backspace
force-pushed
the
matrix-sse-cs-7916
branch
from
931361f to
e5dd9b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just preparatory steps for now.