Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CS-8031 Spec Preview to use props drilling pattern to get cards #2231

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

richardhjtan
Copy link
Contributor

@richardhjtan richardhjtan commented Feb 28, 2025

Refer to https://linear.app/cardstack/issue/CS-8031/improve-auto-save-typing-in-spec

What is changing

Before

Screen.Recording.2025-03-01.at.12.06.39.AM.mov

After

Screen.Recording.2025-02-28.at.11.51.48.PM.mov

Copy link

github-actions bot commented Feb 28, 2025

Host Test Results

    1 files  ±0      1 suites  ±0   23m 49s ⏱️ -41s
787 tests ±0  785 ✔️ ±0  2 💤 ±0  0 ±0 
792 runs  ±0  790 ✔️ ±0  2 💤 ±0  0 ±0 

Results for commit f01e3cf. ± Comparison against base commit 0c08ab6.

♻️ This comment has been updated with latest results.

@richardhjtan richardhjtan changed the title CS-8031 fix boxel spec create new component when rerender issue CS-8031 Spec Preview to use props drilling pattern to get cards Feb 28, 2025
@richardhjtan richardhjtan requested review from tintinthong and a team February 28, 2025 16:08
@richardhjtan richardhjtan marked this pull request as ready for review February 28, 2025 16:09
Copy link
Contributor

@backspace backspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reran the host tests to hopefully remove the spurious Percy font diff 🤞🏻

Copy link
Contributor

@tintinthong tintinthong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks!

Copy link
Contributor

@tintinthong tintinthong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm this fixes auto-save

BUT

  1. Why can't I create a spec and have it rendered?? I thought test wud capture this. EDIT: I think this happens unreliably. Chris has told me this happens but after implementing auto-save I found it to be reliable -- can look at it independently.

  2. Also rendering the boxel input, I see. I think need test to check this

Screenshot 2025-03-01 at 09 10 36
  1. In scenarios where there are more than spec, choosing a dropdown card didn't re-render to new card

@richardhjtan richardhjtan requested a review from tintinthong March 3, 2025 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants