-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CS-8031 Spec Preview to use props drilling pattern to get cards #2231
base: main
Are you sure you want to change the base?
CS-8031 Spec Preview to use props drilling pattern to get cards #2231
Conversation
…when-rerender-issue-1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reran the host tests to hopefully remove the spurious Percy font diff 🤞🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirm this fixes auto-save
BUT
-
Why can't I create a spec and have it rendered?? I thought test wud capture this. EDIT: I think this happens unreliably. Chris has told me this happens but after implementing auto-save I found it to be reliable -- can look at it independently.
-
Also rendering the boxel input, I see. I think need test to check this

- In scenarios where there are more than spec, choosing a dropdown card didn't re-render to new card
Refer to https://linear.app/cardstack/issue/CS-8031/improve-auto-save-typing-in-spec
What is changing
Before
Screen.Recording.2025-03-01.at.12.06.39.AM.mov
After
Screen.Recording.2025-02-28.at.11.51.48.PM.mov