Fix Xcode errors when using Framework in SPM #679
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like to dig into the place where we use the mapping model before we think about removing it. I wouldn't want this to disappear if the framework specifies the file during the migration process. If migration is left up to the client, removing it might be okay for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One way to partially address #665 is to exclude the migrations file,
CoreData/Migrations/2_0To2_1/2.0_2.1_Mapping.xcmappingmodelwhen using SPM. Though this is not ideal, we can recommend that users who need to migrate from an old version of OCKStore use drop the CareKit project into their projects directly as specified in #665 (comment).People already using the current data store won't be effected by this change.