Make sure the fps change has been accepted by camera before finishing… #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattalvarado
reviewed
Aug 6, 2024
| @@ -1927,6 +1927,35 @@ void Camera::timerCallback() | |||
| } | |||
| } | |||
|
|
|||
| crl::multisense::Status Camera::verifyFpsChange(const crl::multisense::image::Config& config) | |||
There was a problem hiding this comment.
@psmithcrl Is FPS the only parameter which needs to be confirmed like this? Out of curiosity what failure were you seeing by setting the FPS once?
There was a problem hiding this comment.
Found the thread on slack. Sorry
|
My preference would be we close this PR since this is now fixed in firmware newer than 7.06 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure the fps change has been accepted by camera before finishing reconfiguration.
FPS can take the camera time to apply and can result in a failed setting if queried too quickly.