Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for setting up Python through renv #448

Open
wants to merge 80 commits into
base: main
Choose a base branch
from
Open

Add support for setting up Python through renv #448

wants to merge 80 commits into from

Commits on Apr 28, 2023

  1. Set dev version

    @milanmlft
    milanmlft committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    70027f9 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2023

  1. Add use_python() helper

    @milanmlft
    milanmlft committed May 2, 2023
    Configuration menu
    Copy the full SHA
    51c6995 View commit details
    Browse the repository at this point in the history

  2. Add py_install() helpeer to add Python dependencies

    @milanmlft
    milanmlft committed May 2, 2023
    Configuration menu
    Copy the full SHA
    9623395 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. Reactivate renv profile after adding Python 

    Workaround for rstudio/renv#1217
    @milanmlft
    milanmlft committed May 3, 2023
    Configuration menu
    Copy the full SHA
    1495f89 View commit details
    Browse the repository at this point in the history

  2. Make sure Python dependencies also get restored by manage_deps()

    @milanmlft
    milanmlft committed May 3, 2023
    Configuration menu
    Copy the full SHA
    cea48bf View commit details
    Browse the repository at this point in the history

  3. Add option to set up Python in create_lesson()

    @milanmlft
    milanmlft committed May 3, 2023
    Configuration menu
    Copy the full SHA
    28425e8 View commit details
    Browse the repository at this point in the history

  4. Set working directory while setting up Python 

    Avoids some undesirable renv side effects.
    @milanmlft
    milanmlft committed May 3, 2023
    Configuration menu
    Copy the full SHA
    b729c0c View commit details
    Browse the repository at this point in the history

  5. Update documentation for create_lesson()

    @milanmlft
    milanmlft committed May 3, 2023
    Configuration menu
    Copy the full SHA
    5ffacc6 View commit details
    Browse the repository at this point in the history

  6. Update documentation for use_python()

    @milanmlft
    milanmlft committed May 3, 2023
    Configuration menu
    Copy the full SHA
    669141c View commit details
    Browse the repository at this point in the history

  7. Reoxygenize

    @milanmlft
    milanmlft committed May 3, 2023
    Configuration menu
    Copy the full SHA
    0b45377 View commit details
    Browse the repository at this point in the history

  8. Add examples for Python usage

    @milanmlft
    milanmlft committed May 3, 2023
    Configuration menu
    Copy the full SHA
    4529311 View commit details
    Browse the repository at this point in the history

  9. Add unit tests for Python integration

    @milanmlft
    milanmlft committed May 3, 2023
    Configuration menu
    Copy the full SHA
    ec2599f View commit details
    Browse the repository at this point in the history

  10. Also test that manage_deps() plays nice with Python integration

    @milanmlft
    milanmlft committed May 3, 2023
    Configuration menu
    Copy the full SHA
    cc05834 View commit details
    Browse the repository at this point in the history

  11. Document

    @zkamvar
    zkamvar committed May 3, 2023
    Configuration menu
    Copy the full SHA
    1dd787a View commit details
    Browse the repository at this point in the history

Commits on May 17, 2023

  1. Merge branch 'main' into use_python

    @milanmlft
    milanmlft authored May 17, 2023
    Configuration menu
    Copy the full SHA
    41edc10 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2023

  1. Refactor: move reticulate installation to separate helper

    @milanmlft
    milanmlft committed May 22, 2023
    Configuration menu
    Copy the full SHA
    df07005 View commit details
    Browse the repository at this point in the history

  2. Improve tests, add helpers to manage renv during testing

    @milanmlft
    milanmlft committed May 22, 2023
    Configuration menu
    Copy the full SHA
    7deb07d View commit details
    Browse the repository at this point in the history

  3. Use requireNamespace() instead of require()

    @milanmlft
    milanmlft committed May 22, 2023
    Configuration menu
    Copy the full SHA
    ac15e6c View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into use_python

    @milanmlft
    milanmlft committed May 22, 2023
    Configuration menu
    Copy the full SHA
    76c814d View commit details
    Browse the repository at this point in the history

  5. Set dev version

    @milanmlft
    milanmlft committed May 22, 2023
    Configuration menu
    Copy the full SHA
    2df6d49 View commit details
    Browse the repository at this point in the history

  6. Skip manage_deps() tests on Windows

    @milanmlft
    milanmlft committed May 22, 2023
    Configuration menu
    Copy the full SHA
    d096467 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2023

  1. Skip use_python tests on Windows 

    Not sure why they are not working. Assuming it has to do with renv.
    @milanmlft
    milanmlft committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    fde134b View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. Check that reticulate can be installed and warn if it does not

    @milanmlft
    milanmlft committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    680c74e View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. Merge branch 'main' into use_python

    @milanmlft
    milanmlft authored Jun 9, 2023
    Configuration menu
    Copy the full SHA
    a3a4d91 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2023

  1. Small bug fix

    @milanmlft
    milanmlft committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    da24671 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Add use_python to pkgdown config

    @milanmlft
    milanmlft committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    a589e1c View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2023

  1. Get R CMD check to succeed on oldrel-4

    @milanmlft
    milanmlft committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    69c62b7 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2023

  1. Merge branch 'main' into use_python

    @zkamvar
    zkamvar authored Sep 8, 2023
    Configuration menu
    Copy the full SHA
    9ed3a0b View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. Merge branch 'main' into use_python

    @milanmlft
    milanmlft committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    e127abe View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. Merge branch 'main' into use_python

    @milanmlft
    milanmlft committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    b467cea View commit details
    Browse the repository at this point in the history

  2. Make sure the correct project is loaded in renv

    @milanmlft
    milanmlft committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    9f99900 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. Tests: add with_renv_profile() helper 

    Allows running relevant checks with the test lesson's renv profile.
    @milanmlft
    milanmlft committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    5869aaf View commit details
    Browse the repository at this point in the history

  2. Add option to open lesson project in use_python()

    @milanmlft
    milanmlft committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    0ebc409 View commit details
    Browse the repository at this point in the history

  3. Add with_renv_factory() helper

    @milanmlft
    milanmlft committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    bd62492 View commit details
    Browse the repository at this point in the history

  4. Refactor use_python functions to use with_renv_factory() 

    Avoids renv side effects when running in interactive sessions
    @milanmlft
    milanmlft committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    3a629cd View commit details
    Browse the repository at this point in the history

  5. Bug fix for local_load_py_pkg(); need to unquote argument

    @milanmlft
    milanmlft committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    4833219 View commit details
    Browse the repository at this point in the history

  6. Load Python packages from renv environment in tests

    @milanmlft
    milanmlft committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    fab1a3a View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. Create pull.yml

    @milanmlft
    milanmlft authored Nov 7, 2023
    Configuration menu
    Copy the full SHA
    e7fe196 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from carpentries/main 

    [pull] main from carpentries:main
    @milanmlft
    milanmlft authored Nov 7, 2023
    Configuration menu
    Copy the full SHA
    90ab41c View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2023

  1. Merge pull request #2 from carpentries/main 

    [pull] main from carpentries:main
    @milanmlft
    milanmlft authored Nov 10, 2023
    Configuration menu
    Copy the full SHA
    7947908 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. Merge pull request #3 from carpentries/main 

    [pull] main from carpentries:main
    @milanmlft
    milanmlft authored Nov 13, 2023
    Configuration menu
    Copy the full SHA
    65f7234 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. Merge pull request #4 from carpentries/main 

    [pull] main from carpentries:main
    @milanmlft
    milanmlft authored Nov 15, 2023
    Configuration menu
    Copy the full SHA
    5a63272 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. Merge pull request #5 from carpentries/main 

    [pull] main from carpentries:main
    @milanmlft
    milanmlft authored Nov 16, 2023
    Configuration menu
    Copy the full SHA
    d34036d View commit details
    Browse the repository at this point in the history

  2. Use default pull config

    @milanmlft
    milanmlft committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    694f66d View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. Merge pull request #7 from carpentries/main 

    [pull] main from carpentries:main
    @milanmlft
    milanmlft authored Nov 22, 2023
    Configuration menu
    Copy the full SHA
    99a46b4 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2023

  1. Merge pull request #8 from carpentries/main 

    [pull] main from carpentries:main
    @milanmlft
    milanmlft authored Nov 23, 2023
    Configuration menu
    Copy the full SHA
    753a111 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2023

  1. Merge pull request #9 from carpentries/main 

    [pull] main from carpentries:main
    @milanmlft
    milanmlft authored Nov 30, 2023
    Configuration menu
    Copy the full SHA
    31ba581 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2023

  1. Merge remote-tracking branch 'upstream/main' into use_python

    @milanmlft
    milanmlft committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    87d29d7 View commit details
    Browse the repository at this point in the history

  2. Fix manage_deps() Python-related tests 

    Activate Python outside of `test_that()` blocks
    @milanmlft
    milanmlft committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    6360ece View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. Allow for multiple lines in requirements.txt during tests

    @milanmlft
    milanmlft committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    32593ed View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. Merge pull request #10 from carpentries/main 

    [pull] main from carpentries:main
    @milanmlft
    milanmlft authored Dec 12, 2023
    Configuration menu
    Copy the full SHA
    47d803a View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. Merge pull request #11 from carpentries/main 

    [pull] main from carpentries:main
    @milanmlft
    milanmlft authored Dec 13, 2023
    Configuration menu
    Copy the full SHA
    6d69475 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Merge pull request #12 from carpentries/main 

    [pull] main from carpentries:main
    @milanmlft
    milanmlft authored Dec 15, 2023
    Configuration menu
    Copy the full SHA
    63067e2 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2023

  1. Merge pull request #13 from carpentries/main 

    [pull] main from carpentries:main
    @milanmlft
    milanmlft authored Dec 21, 2023
    Configuration menu
    Copy the full SHA
    85259cf View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2024

  1. Merge pull request #14 from carpentries/main 

    [pull] main from carpentries:main
    @milanmlft
    milanmlft authored Jan 15, 2024
    Configuration menu
    Copy the full SHA
    da74bb1 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Merge pull request #15 from carpentries/main 

    [pull] main from carpentries:main
    @milanmlft
    milanmlft authored Jan 23, 2024
    Configuration menu
    Copy the full SHA
    8a9b751 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. Merge pull request #16 from carpentries/main 

    [pull] main from carpentries:main
    @milanmlft
    milanmlft authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    4204aa3 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Merge branch 'main' into use_python

    @milanmlft
    milanmlft committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    5f3580f View commit details
    Browse the repository at this point in the history

  2. Minor test fixes 

    Correctly check for lines in `requirements.txt`
    @milanmlft
    milanmlft committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    57923a8 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Merge pull request #17 from carpentries/main 

    [pull] main from carpentries:main
    @milanmlft
    milanmlft authored Mar 18, 2024
    Configuration menu
    Copy the full SHA
    e5595ba View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Merge pull request #18 from carpentries/main 

    [pull] main from carpentries:main
    @milanmlft
    milanmlft authored Apr 8, 2024
    Configuration menu
    Copy the full SHA
    7ad44c8 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Merge pull request #19 from carpentries/main 

    [pull] main from carpentries:main
    @milanmlft
    milanmlft authored Apr 17, 2024
    Configuration menu
    Copy the full SHA
    430a37b View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. Merge pull request #20 from carpentries/main 

    [pull] main from carpentries:main
    @milanmlft
    milanmlft authored Apr 22, 2024
    Configuration menu
    Copy the full SHA
    c98d9f0 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Merge pull request #21 from carpentries/main 

    [pull] main from carpentries:main
    @milanmlft
    milanmlft authored May 10, 2024
    Configuration menu
    Copy the full SHA
    d9fc5a7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into use_python

    @milanmlft
    milanmlft committed May 10, 2024
    Configuration menu
    Copy the full SHA
    bf8a3a8 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Merge pull request #22 from carpentries/main 

    [pull] main from carpentries:main
    @milanmlft
    milanmlft authored May 30, 2024
    Configuration menu
    Copy the full SHA
    0b96097 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. Merge branch 'main' of github.com:carpentries/sandpaper

    @milanmlft
    milanmlft committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    8b51785 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:milanmlft/sandpaper

    @milanmlft
    milanmlft committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    6243835 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into use_python

    @milanmlft
    milanmlft committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    1fa6880 View commit details
    Browse the repository at this point in the history

  4. Add quiet option for use_python

    @milanmlft
    milanmlft committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    857421b View commit details
    Browse the repository at this point in the history

  5. Test that update_cache() doesn't remove Python dependencies

    @milanmlft
    milanmlft committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    fe9311d View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Use a real Python package to test update_cache()

    @milanmlft
    milanmlft committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    5893b4d View commit details
    Browse the repository at this point in the history

  2. Make sure current requirements are installed before updating cache 

    Fixes LearnToDiscover#68
    @milanmlft
    milanmlft committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    6119227 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. Don't overwrite existing requirements.txt file in tests

    @milanmlft
    milanmlft committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    2131f99 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Make sure with_renv_factory deactivates renv upon completion

    @milanmlft
    milanmlft committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    d28e74a View commit details
    Browse the repository at this point in the history

  2. Refactor update_cache() to use with_renv_factory()

    @milanmlft
    milanmlft committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    94c5c9c View commit details
    Browse the repository at this point in the history

  3. Clean up tests

    @milanmlft
    milanmlft committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    4631869 View commit details
    Browse the repository at this point in the history

  4. roxygenise

    @milanmlft
    milanmlft committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    3540c99 View commit details
    Browse the repository at this point in the history

  5. Add mising param doc

    @milanmlft
    milanmlft committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    2330acd View commit details
    Browse the repository at this point in the history

  6. Use smaller Python package to speed up test

    @milanmlft
    milanmlft committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    7143242 View commit details
    Browse the repository at this point in the history