Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update var names to match updated exclusion names #61

Open
dchud opened this issue Jun 13, 2021 · 0 comments
Open

Update var names to match updated exclusion names #61

dchud opened this issue Jun 13, 2021 · 0 comments
Labels
easy Should take two hours or less

Comments

@dchud
Copy link
Collaborator

dchud commented Jun 13, 2021

In #59, the exclusion category Exclude-Same-Day-Extraneous was renamed to Exclude-Adult-Extraneous-Same-Day to match the similar exclusion for peds. In code, several vars related to this (e.g. sde_vars, orig_sde, mean_sde, temp_sde) might be best renamed to esd to limit the cognitive load of referring to them with an abbreviation that doesn't match the reordered exclusion name.

Verify whether any additional variables should be renamed as well as a result of renames in #59.

@dchud dchud mentioned this issue Jun 13, 2021
4 tasks
@dchud dchud added the easy Should take two hours or less label Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy Should take two hours or less
Projects
None yet
Development

No branches or pull requests

1 participant