Add a sync file from S3 feature #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagmoreira
reviewed
Jan 6, 2025
There was a problem hiding this comment.
I like this idea a lot. I have a few questions:
- Can you also create documentation for this new command? I'm not sure how to specify the source S3 path. Do we need to include the
s3://prefix? - Is rclone installed by default on most unix distributions? If not, should we give instructions to the user on how to install it?
- sync and rsync are very similar commands. Is it better to update rsync to first detect if the source path is local or S3 and then use rsync or rclone appropriately?
| @@ -142,6 +142,7 @@ def add_action_args(parser): | |||
| """ | |||
| action_grp = parser.add_argument_group('Action Arguments') | |||
| action_grp.add_argument('--rsync_path', '--rsync-path') | |||
| action_grp.add_argument('--sync_path', '--rclone-path') | |||
There was a problem hiding this comment.
Should the second string be --sync-path?
| @@ -0,0 +1,107 @@ | |||
| """Rsync user content to EC2 instance.""" | |||
There was a problem hiding this comment.
This module docstring needs updating
| pem_secret = config['forge_pem_secret'] | ||
| region = config['region'] | ||
| profile = config.get('aws_profile') | ||
| rsync_loc = config.get('sync_path', config.get('app_dir')) |
There was a problem hiding this comment.
I would change this variable to sync_loc or rclone_loc for consistency and to avoid confusion with the rsync command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability for Forge to sync a file from S3 to an instance. The new
syncaction adds this. It uses rclone instead of rsync to allow for files to be sent from the local machine, s3, or any other cloud storage provider. It is currently set up for AWS only but this can be expanded in future updates.