chore: clippy

crates/common/src/lib.rs

@@ -424,7 +424,7 @@ impl ChainId {
     pub fn as_str(&self) -> &str {
         std::str::from_utf8(self.0.as_be_bytes())
             .expect("valid utf8")
-            .trim_start_matches(|c| c == '\0')
+            .trim_start_matches('\0')
     }
 
     pub const MAINNET: Self = Self::from_slice_unwrap(b"SN_MAIN");

crates/executor/src/simulate.rs

@@ -198,12 +198,11 @@ pub fn trace(
                 cache.cache_set(block_hash, CacheItem::CachedErr(err.clone()));
                 err
             })?;
-        let state_diff =
-            to_state_diff(&mut tx_state, tx_declared_deprecated_class_hash).map_err(|e| {
+        let state_diff = to_state_diff(&mut tx_state, tx_declared_deprecated_class_hash)
+            .inspect_err(|_| {
                 // Remove the cache entry so it's no longer inflight.
                 let mut cache = cache.0.lock().unwrap();
                 cache.cache_remove(&block_hash);
-                e
             })?;
         tx_state.commit();
 

crates/gateway-client/src/metrics.rs

@@ -166,7 +166,7 @@ pub async fn with_metrics<T>(
 
     metrics::histogram!(METRIC_REQUESTS_LATENCY, elapsed, "method" => meta.method);
 
-    result.map_err(|e| {
+    result.inspect_err(|e| {
         increment(METRIC_FAILED_REQUESTS, meta);
 
         match &e {
@@ -191,7 +191,5 @@ pub async fn with_metrics<T>(
             }
             SequencerError::ReqwestError(_) => {}
         }
-
-        e
     })
 }