Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix incompatible trait implementation with Casbin-rs 2.1.0 #84

Merged
merged 2 commits into from
Dec 17, 2023

Conversation

Peterburnett
Copy link
Contributor

Closes #83

@CLAassistant
Copy link

CLAassistant commented Dec 13, 2023

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1f930b9) 69.49% compared to head (1a8c975) 70.19%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
+ Coverage   69.49%   70.19%   +0.70%     
==========================================
  Files           3        4       +1     
  Lines         295      302       +7     
==========================================
+ Hits          205      212       +7     
  Misses         90       90              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hsluoyz
Copy link
Member

hsluoyz commented Dec 14, 2023

@Peterburnett plz fix:

image

@Peterburnett
Copy link
Contributor Author

The failing item is not from my PR, and is unrelated. Happy to add a commit to fix later on today.

@Peterburnett
Copy link
Contributor Author

@hsluoyz I've pushed a fix for the clippy error. Can you please kick off the CI run again?
Thanks!

@hsluoyz
Copy link
Member

hsluoyz commented Dec 15, 2023

@Peterburnett thanks. It got fixed.

Another issue showed up:

image

@Peterburnett
Copy link
Contributor Author

@hsluoyz this is not from my code as far as I can tell, and I have no idea what the CI implementation/best practices are for this project. I don't think I am in the best position to fix the MacOS dependencies, as I am not a mac user or have experience managing python toolchains

@hsluoyz hsluoyz changed the title Issue #83: Update trait definition for casbin-rs 2.1.0 feat: fix incompatible trait implementation with Casbin-rs 2.1.0 Dec 17, 2023
@hsluoyz hsluoyz merged commit 25c841a into casbin-rs:master Dec 17, 2023
6 of 10 checks passed
@Peterburnett Peterburnett deleted the issue-83 branch December 17, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatible trait implementation with Casbin-rs 2.1.0
4 participants