Test for IRIs that share UUIDs #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses Issue 264. This was among shared UUID usages found while reviewing CASE-Examples-QC PR 54. A follow-on patch will regenerate Make-managed files. References: * ajnelson-nist/CASE-Examples-QC#54 * #264 Signed-off-by: Alex Nelson <[email protected]>
References: * ajnelson-nist/CASE-Examples-QC#54 * #264 Signed-off-by: Alex Nelson <[email protected]>
This was among shared UUID usages found while reviewing CASE-Examples-QC PR 54. A follow-on patch will regenerate Make-managed files. References: * ajnelson-nist/CASE-Examples-QC#54 Signed-off-by: Alex Nelson <[email protected]>
References: * ajnelson-nist/CASE-Examples-QC#54 Signed-off-by: Alex Nelson <[email protected]>
This was among shared UUID usages found while reviewing CASE-Examples-QC PR 54. This patch purposefully aligns the two IRIs in case there was a data-design reason the node appeared in both examples. A follow-on patch will regenerate Make-managed files. References: * ajnelson-nist/CASE-Examples-QC#54 Signed-off-by: Alex Nelson <[email protected]>
References: * ajnelson-nist/CASE-Examples-QC#54 Signed-off-by: Alex Nelson <[email protected]>
This was among shared UUID usages found while reviewing CASE-Examples-QC PR 54. A follow-on patch will regenerate Make-managed files. References: * ajnelson-nist/CASE-Examples-QC#54 Signed-off-by: Alex Nelson <[email protected]>
References: * ajnelson-nist/CASE-Examples-QC#54 Signed-off-by: Alex Nelson <[email protected]>
This was among shared UUID usages found while reviewing CASE-Examples-QC PR 54. A follow-on patch will regenerate Make-managed files. References: * ajnelson-nist/CASE-Examples-QC#54 Signed-off-by: Alex Nelson <[email protected]>
References: * ajnelson-nist/CASE-Examples-QC#54 Signed-off-by: Alex Nelson <[email protected]>
This was among shared UUID usages found while reviewing CASE-Examples-QC PR 54. A follow-on patch will regenerate Make-managed files. References: * ajnelson-nist/CASE-Examples-QC#54 Signed-off-by: Alex Nelson <[email protected]>
References: * ajnelson-nist/CASE-Examples-QC#54 Signed-off-by: Alex Nelson <[email protected]>
This was among shared UUID usages found while reviewing CASE-Examples-QC PR 54. A follow-on patch will regenerate Make-managed files. References: * ajnelson-nist/CASE-Examples-QC#54 Signed-off-by: Alex Nelson <[email protected]>
References: * ajnelson-nist/CASE-Examples-QC#54 Signed-off-by: Alex Nelson <[email protected]>
The UUID `99d72bac-8c21-11e9-8902-0c4de9c21b53` was copied between two snippet files. In `crossover_wmd-users_and_accounts.json`, an email account IRI and email address IRI shared the UUID, both seeming to be intended to be for the "Ares Lupin" identity. In `crossover_wmd-email.json`, the email account IRI from `crossover_wmd-users_and_accounts.json` was duplicated and used for the "Harley Quinn" identity, with different attached Facets. This patch separates the email account nodes for Ares and Harley, on belief that they are data crafting errors. This was among shared UUID usages found while reviewing CASE-Examples-QC PR 54. A follow-on patch will regenerate Make-managed files. References: * ajnelson-nist/CASE-Examples-QC#54 Signed-off-by: Alex Nelson <[email protected]>
References: * ajnelson-nist/CASE-Examples-QC#54 Signed-off-by: Alex Nelson <[email protected]>
The UUID `90652808-7341-40d3-9285-774d865ad3f9` was copied between two examples. From review of the Crossover WMD case, it seems a redundant characterization of the Ares Lupin WhatsApp account was added with a modified prefix. The WhatsApp application seemed to have a similar redundant characterization. The JSON nodes in the smaller snippet files were favored. `90652808-7341-40d3-9285-774d865ad3f9` was also used to identify a `DigitalAccount` in the Owl Trafficking example pertaining to a different scenario persona. The UUID there was replaced. This was among shared UUID usages found while reviewing CASE-Examples-QC PR 54. A follow-on patch will regenerate Make-managed files. References: * ajnelson-nist/CASE-Examples-QC#54 Signed-off-by: Alex Nelson <[email protected]>
References: * ajnelson-nist/CASE-Examples-QC#54 Signed-off-by: Alex Nelson <[email protected]>
This was among shared UUID usages found while reviewing CASE-Examples-QC PR 54. A follow-on patch will regenerate Make-managed files. References: * ajnelson-nist/CASE-Examples-QC#54 Signed-off-by: Alex Nelson <[email protected]>
References: * ajnelson-nist/CASE-Examples-QC#54 Signed-off-by: Alex Nelson <[email protected]>
The UUID `39ff4987-8ae5-47e3-8369-dbd0d5f79398` appeared in the mapped tool data. The CASE graph forwarded it to a URL node, and then it appears there were subsequent copies of the UUID as other example data was drafted. This patch removes all occurrences of the UUID from the CASE graph(s), because it is not clear (to me) whether the mapped object from the tool's data model corresponds to a UCO `URL` object. It more appears (to me) to correspond to a `URLHistory` object. This was among shared UUID usages found while reviewing CASE-Examples-QC PR 54. A follow-on patch will regenerate Make-managed files. References: * ajnelson-nist/CASE-Examples-QC#54 Signed-off-by: Alex Nelson <[email protected]>
References: * ajnelson-nist/CASE-Examples-QC#54 Signed-off-by: Alex Nelson <[email protected]>
This was among shared UUID usages found while reviewing CASE-Examples-QC PR 54. A follow-on patch will regenerate Make-managed files. References: * ajnelson-nist/CASE-Examples-QC#54 Signed-off-by: Alex Nelson <[email protected]>
References: * ajnelson-nist/CASE-Examples-QC#54 Signed-off-by: Alex Nelson <[email protected]>
This was among shared UUID usages found while reviewing CASE-Examples-QC PR 54. A follow-on patch will regenerate Make-managed files. References: * ajnelson-nist/CASE-Examples-QC#54 Signed-off-by: Alex Nelson <[email protected]>
References: * ajnelson-nist/CASE-Examples-QC#54 Signed-off-by: Alex Nelson <[email protected]>
This was among shared UUID usages found while reviewing CASE-Examples-QC PR 54. A follow-on patch will regenerate Make-managed files. References: * ajnelson-nist/CASE-Examples-QC#54 Signed-off-by: Alex Nelson <[email protected]>
References: * ajnelson-nist/CASE-Examples-QC#54 Signed-off-by: Alex Nelson <[email protected]>
This patch adds a compilation of all kb graphs as a non-persisted artifact. The benefit of this graph is, so far, finding duplicated-node errors. This patch ports the workflow update from CASE-Examples PR 132. This patch is part of realizing CASE-Examples-QC PR 54. No effects were observed on Make-managed files. References: * ajnelson-nist/CASE-Examples-QC#54 * casework/CASE-Examples#132 Signed-off-by: Alex Nelson <[email protected]>
This is part of implementing CASE-Examples-QC PR 54. No effects were observed on Make-managed files. References: * ajnelson-nist/CASE-Examples-QC#54 Signed-off-by: Alex Nelson <[email protected]>
|
Summary of changes:
This is an aggregation of testing implemented in CASE-Examples PRs 132 and 143. |
|
This PR is ready for review and merge. |
kchason
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of implementing CASE-Examples-QC PR 54.
This PR is built on top of PR 293.