Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CashuWallet.ts' comment corrections #215

Open
wants to merge 14 commits into
base: development
Choose a base branch
from

Conversation

Gudnessuche
Copy link

Fixes: #[]

Description

Comments aren't 100% punctuated

Changes

Made the comments more grammatically correct by adding proper punctuations as well as capitalization of words after a period.

This miniscule change is a perfectionist's view for the grammatical correctness that this file deserves.

Egge21M and others added 12 commits September 8, 2024 21:10
Made the comments more grammatically correct by adding proper punctuations as well as capitalization of words after a period.

This miniscule change is a perfectionist's view for the grammatical correctness that this file deserves.
remove version stuff from readme, since we follow a different pattern now
Copy link
Contributor

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no functional changes

changes only in comments 👍

Copy link
Contributor

@mubarak23 mubarak23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM

@Egge21M
Copy link
Collaborator

Egge21M commented Dec 17, 2024

LGTM. Thank you for taking care of this. Please target the development branch and make sure your branch is up to date

@Gudnessuche
Copy link
Author

made sure my branch is up to date already

@Gudnessuche Gudnessuche changed the base branch from main to development December 17, 2024 15:14
@Egge21M
Copy link
Collaborator

Egge21M commented Dec 18, 2024

@Gudnessuche please resolve conflicts. You merged main not development

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants