Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding
tos
field toMintInfo
(nut06.rs) and updated the cdk-sqlite migration in the wallet.Notes to the reviewers
I saw the not in the NUT-06 reference about using
tos_url
but didn't see any strong push to use that over a stringtos
. In my opinion, a client that is implementing this could use a uri parser to evaluate if the `tos is a uri or if it's just text.The sqlx migration is in place for the
cdk-sqlite
crate. Might be nice at some point to have a set of integration tests similar to thetest_swap_send
but for thecdk-sqlite
Suggested CHANGELOG Updates
CHANGED
ADDED
Added a
tos
field type ofString
to theMintInfo
struct.REMOVED
FIXED
Update the comment
NIP-06
to readNUT-06
Checklist
just final-check
before committing