Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding tos to mint #604

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nodlAndHodl
Copy link

Description

Adding tos field to MintInfo (nut06.rs) and updated the cdk-sqlite migration in the wallet.


Notes to the reviewers

I saw the not in the NUT-06 reference about using tos_url but didn't see any strong push to use that over a string tos. In my opinion, a client that is implementing this could use a uri parser to evaluate if the `tos is a uri or if it's just text.

The sqlx migration is in place for the cdk-sqlite crate. Might be nice at some point to have a set of integration tests similar to the test_swap_send but for the cdk-sqlite


Suggested CHANGELOG Updates

CHANGED

ADDED

Added a tos field type of String to the MintInfostruct.

REMOVED

FIXED

Update the comment NIP-06 to read NUT-06


Checklist

@nodlAndHodl nodlAndHodl force-pushed the feature/add-tos-mintinfo branch from cfee53d to 89d1401 Compare February 14, 2025 14:31
@nodlAndHodl nodlAndHodl force-pushed the feature/add-tos-mintinfo branch from 89d1401 to e848b8d Compare February 14, 2025 14:36
@thesimplekid
Copy link
Collaborator

Thanks for this PR LGTM we'll just have to wait for consensus on the nut.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants