Add fees to NUT-02 #126
Merged
Add fees to NUT-02 #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callebtc
requested review from
AngusP,
thesimplekid,
ebrakke,
thunderbiscuit,
BilligsterUser,
Egge21M and
gandlafbtc
elnosh
reviewed
May 29, 2024
|
unintended side effect: this has a negative effect on privacy measures and offline spending |
conduition
reviewed
Jun 4, 2024
gandlafbtc
reviewed
Jun 6, 2024
callebtc
referenced
this pull request
in cashubtc/nutshell
Jun 16, 2024
Co-authored-by: gandlafbtc <[email protected]>
callebtc
referenced
this pull request
in cashubtc/nutshell
Jun 16, 2024
callebtc
added
breaking change
conduition
reviewed
Jun 18, 2024
| def fees(inputs: List[Proof]) -> int: | ||
| sum_fees = 0 | ||
| for proof in inputs: | ||
| sum_fees += keysets[proof.id].input_fee_ppk |
There was a problem hiding this comment.
Still missing proof.amount here:
Suggested change
| sum_fees += keysets[proof.id].input_fee_ppk | |
| sum_fees += proof.amount * keysets[proof.id].input_fee_ppk |
There was a problem hiding this comment.
Still missing
proof.amounthere:
The fees are not amount-dependent.
thesimplekid
approved these changes
Jun 27, 2024
Egge21M
approved these changes
Jun 27, 2024
elnosh
approved these changes
Jun 27, 2024
Closed
|
merged in nutmix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposing to add fees to the mandatory part of the spec as I expect most public mints will require fees at some point. If the fees are not set, we should assume it as being 0.
Moved around some existing text. The new part is:
Fees (parts per thousand)
Keysets indicate the fee
input_fee_ppkthat is charged when aProofof that keyset is spent as an input to a transaction. The fee is given in parts per thousand (ppk) per input measured in theunitof the keyset and the sum is rounded up to the next larger integer.As an example, we construct a transaction spending 3 inputs (
Proofs) from a keyset with unitsatandinput_fee_ppkof100. A fee of100 ppkmeans0.1 satper input. The sum of the fees would be 300 ppk for this transaction and the mint would charge1 satin fees (ceil(0.3) == 1). The fees for spending 1-10 inputs is 1 sat, 11-20 inputs is 2 sat and so on....
Wallet input and output construction
When constructing a transaction with ecash inputs (example:
/v1/swapor/v1/melt), wallets MUST add fees to the inputs (or subtract from the outputs) if they spent ecash from a keyset with fees. The mint checks the following equation:The
feesare calculated for each input individually (by summing the fee from the keyset they are from) and then rounded up to the next integer.Tracking progress
Mints:
Wallets