Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin compile args #294

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Kotlin compile args #294

merged 3 commits into from
Oct 30, 2023

Conversation

casid
Copy link
Owner

@casid casid commented Oct 30, 2023

This should fix #293.

Ideally, this would pick up the required JDK version from the project configuration (like maven does this for Java), but I have no idea how to do that for Kotlin.

For now, this would need to be added to the precompile task:

jte {
    precompile()
    kotlinCompileArgs.set(arrayOf("-jvm-target", "17"))
}

@casid casid self-assigned this Oct 30, 2023
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (dd8b9f5) 91.22% compared to head (40b0356) 91.21%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #294      +/-   ##
============================================
- Coverage     91.22%   91.21%   -0.01%     
- Complexity     1193     1197       +4     
============================================
  Files            76       76              
  Lines          3123     3132       +9     
  Branches        482      484       +2     
============================================
+ Hits           2849     2857       +8     
  Misses          167      167              
- Partials        107      108       +1     
Files Coverage Δ
...e-runtime/src/main/java/gg/jte/TemplateConfig.java 100.00% <ø> (ø)
...e-runtime/src/main/java/gg/jte/TemplateEngine.java 94.11% <100.00%> (+0.10%) ⬆️
...va/gg/jte/compiler/kotlin/KotlinClassCompiler.java 82.35% <85.71%> (+0.53%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@casid casid merged commit fd9466d into main Oct 30, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to change jvmTarget
1 participant