Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix models extension code generation for tags/templates in subfolders #324

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

marcospereira
Copy link
Contributor

What

When generating code, the jte-models extension does not use the fully-qualified class name for tags/templates in subfolders (therefore, sub-packages). This results in compilation errors.

Also, it adds a new Gradle project that:

  • Use jte-models extensions
  • Generate Kotlin code

Having a project is better than simply adding more unit tests since it will mimic the experience users have. The new test project is a copy of test/jte-runtime-cp-test-models-gradle, but adapted for Kotlin.

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ce83cc9) 91.23% compared to head (23652e4) 91.23%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #324   +/-   ##
=========================================
  Coverage     91.23%   91.23%           
  Complexity     1216     1216           
=========================================
  Files            76       76           
  Lines          3159     3159           
  Branches        492      492           
=========================================
  Hits           2882     2882           
  Misses          164      164           
  Partials        113      113           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcospereira marcospereira force-pushed the models-extension/fix-imports branch from d261a79 to 23652e4 Compare January 26, 2024 18:31
@casid casid merged commit a399772 into casid:main Jan 26, 2024
8 checks passed
@casid
Copy link
Owner

casid commented Jan 26, 2024

Wow, that was quick. Thank you for fixing this @marcospereira.

@marcospereira marcospereira deleted the models-extension/fix-imports branch January 26, 2024 20:22
@marcospereira
Copy link
Contributor Author

Wow, that was quick. Thank you for fixing this @marcospereira.

Thanks! I think it would be good to have 3.1.8 release to replace the broken 3.1.7. But it is Friday, so if releasing takes too much of your time, maybe just put a note on the 3.1.7 release about the issue. :-)

@casid
Copy link
Owner

casid commented Jan 27, 2024

I just released 3.1.8 and left a note on the 3.1.7 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants