Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-escaping-double-quotes #330

Merged
merged 2 commits into from
Feb 10, 2024
Merged

fix-escaping-double-quotes #330

merged 2 commits into from
Feb 10, 2024

Conversation

mhdeeb
Copy link
Contributor

@mhdeeb mhdeeb commented Feb 10, 2024

Previous version fails${"\\\"\\"}. This fix accounts for that.

@mhdeeb mhdeeb changed the title Main fix-escaping-double-quotes Feb 10, 2024
@mhdeeb
Copy link
Contributor Author

mhdeeb commented Feb 10, 2024

Apologies, I should have added that change to the other PR but this is the first time I PR so I didn't think about it.

@casid
Copy link
Owner

casid commented Feb 10, 2024

Good catch, nice!

One minor thing. Could you please leave the other test as is and add your test as a second one? I think it would be good to test both cases.

Copy link

codecov bot commented Feb 10, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ceaa1d2) 91.22% compared to head (6b768a8) 91.17%.

Files Patch % Lines
.../src/main/java/gg/jte/compiler/TemplateParser.java 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #330      +/-   ##
============================================
- Coverage     91.22%   91.17%   -0.05%     
  Complexity     1213     1213              
============================================
  Files            76       76              
  Lines          3155     3160       +5     
  Branches        488      490       +2     
============================================
+ Hits           2878     2881       +3     
- Misses          165      167       +2     
  Partials        112      112              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mhdeeb
Copy link
Contributor Author

mhdeeb commented Feb 10, 2024

Sure, although I think the new test accounts for both if I am not mistaken.

@mhdeeb
Copy link
Contributor Author

mhdeeb commented Feb 10, 2024

Done!

@casid casid merged commit 1daa14b into casid:main Feb 10, 2024
8 checks passed
@casid
Copy link
Owner

casid commented Feb 10, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants