Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation in module enabled applications #416

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

rickardoberg
Copy link
Contributor

Currently it is difficult to use JTE in modularized applications because the compiler does not add modules to class path, so you get class not found issues. This PR simply adds the module path to the class path, which fixes this issue.

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 91.21%. Comparing base (190ced3) to head (d1e4470).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
jte/src/main/java/gg/jte/compiler/ClassUtils.java 20.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #416      +/-   ##
============================================
- Coverage     91.33%   91.21%   -0.12%     
  Complexity     1215     1215              
============================================
  Files            76       76              
  Lines          3161     3166       +5     
  Branches        489      491       +2     
============================================
+ Hits           2887     2888       +1     
- Misses          164      167       +3     
- Partials        110      111       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@casid casid merged commit 0c7d4ad into casid:main Jan 3, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants