WIP: Move old protobuf benchmark into prost #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caspermeijn
force-pushed
the
benchmark
branch
5 times, most recently
from
8ec18a3 to
0865d98
Compare
caspermeijn
force-pushed
the
benchmark
branch
3 times, most recently
from
a7138dc to
bfbc3e3
Compare
Most generated files are untouched when the contents doesn't change. Use the same mechanism for include file as well.
Prevent CI breakage when new lints are added to stable rust version by explicitly choosing the rust version used for the clippy job.
Add the benchmark protos and datasets from protobuf v3.14 to this repo. The upstream benchmarks have been changed (and later removed) in newer versions of the upstream library. This copy ensures that those benchmarks stay available for prost. This is a requirement for updating to newer upstream protobuf version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the benchmark protos and datasets from protobuf v3.14 to this repo. These benchmarks have been changed (and later removed) in newer versions of the upstream library. This copy ensures that those benchmarks stay available for prost. This is a requirement for updating to newer upstream protobuf version.
Open question: