Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translated zh_TW #55

Merged
merged 5 commits into from
Jan 30, 2024
Merged

Translated zh_TW #55

merged 5 commits into from
Jan 30, 2024

Conversation

olivertzeng
Copy link
Contributor

No description provided.

@cassidyjames
Copy link
Owner

Thanks @olivertzeng! However, the localization of the app description seems to be a bit… loaded. 😅 I wonder if there is a nicer way to localize it?

@olivertzeng
Copy link
Contributor Author

olivertzeng commented Aug 2, 2023

@cassidyjames What do you mean by 'loaded'

@cassidyjames
Copy link
Owner

@olivertzeng my Google Translate may be a bit off, but while I understand localizing instead of just directly translating, talking about X/Twitter, military in Taiwan, and mental retardation(?) doesn't really keep the spirit of the original text.

@olivertzeng
Copy link
Contributor Author

@olivertzeng my Google Translate may be a bit off, but while I understand localizing instead of just directly translating, talking about X/Twitter, military in Taiwan, and mental retardation(?) doesn't really keep the spirit of the original text.

Well it's just real 'localizing' I can change it if you want. I swear it's the only part I do jokes

@olivertzeng
Copy link
Contributor Author

Well it doesn't effect the translation I guess

@olivertzeng
Copy link
Contributor Author

@olivertzeng my Google Translate may be a bit off, but while I understand localizing instead of just directly translating, talking about X/Twitter, military in Taiwan, and mental retardation(?) doesn't really keep the spirit of the original text.

Hey @cassidyjames so do I need to correct my text? Or just stay like that, because I really just 'localized' these questions to our styles(these questions are probably the most concerned/curious ones)

Copy link
Owner

@cassidyjames cassidyjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience, @olivertzeng! I left a handful of comments, but this looks mostly good. 😄

@olivertzeng
Copy link
Contributor Author

Thanks for your patience, @olivertzeng! I left a handful of comments, but this looks mostly good. 😄

Thanks for your reply! The legend is back🛐🛐🛐

Do I need to change something for you?

@cassidyjames
Copy link
Owner

@olivertzeng yes, please see the inline comments in the GitHub thread

@olivertzeng
Copy link
Contributor Author

Okay thanks!

@olivertzeng
Copy link
Contributor Author

Fixed

@cassidyjames
Copy link
Owner

@olivertzeng it looks like you missed some of the inline comments, still 😄

@cassidyjames
Copy link
Owner

@olivertzeng sorry about all the git-weirdness, it turns out having the automatic translation updates action is nice, but can also create conflicts. 😬 But you should be good to update anything in this branch, and I'll make sure it gets merged correctly.

@olivertzeng
Copy link
Contributor Author

👍🏼

@olivertzeng
Copy link
Contributor Author

Ive resolved all the issues you gave and fixed a lot of stuff @cassidyjames

Copy link
Contributor Author

@olivertzeng olivertzeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 49 has changed

@olivertzeng
Copy link
Contributor Author

line 49 has changed

Can you please merge my pr?

@olivertzeng
Copy link
Contributor Author

Oh wait it is merged

@olivertzeng
Copy link
Contributor Author

Is it @cassidyjames just want to check

@cassidyjames
Copy link
Owner

@olivertzeng I'm actively working on fixing the conflicts. :) I plan to merge it today and do a new release soon.

@olivertzeng
Copy link
Contributor Author

@olivertzeng I'm actively working on fixing the conflicts. :) I plan to merge it today and do a new release soon.

Great to hear!

@cassidyjames cassidyjames merged commit 6da5f33 into cassidyjames:main Jan 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants