-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translated zh_TW #55
Translated zh_TW #55
Conversation
Thanks @olivertzeng! However, the localization of the app description seems to be a bit… loaded. 😅 I wonder if there is a nicer way to localize it? |
@cassidyjames What do you mean by 'loaded' |
@olivertzeng my Google Translate may be a bit off, but while I understand localizing instead of just directly translating, talking about X/Twitter, military in Taiwan, and mental retardation(?) doesn't really keep the spirit of the original text. |
Well it's just real 'localizing' I can change it if you want. I swear it's the only part I do jokes |
Well it doesn't effect the translation I guess |
Hey @cassidyjames so do I need to correct my text? Or just stay like that, because I really just 'localized' these questions to our styles(these questions are probably the most concerned/curious ones) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience, @olivertzeng! I left a handful of comments, but this looks mostly good. 😄
Thanks for your reply! The legend is back🛐🛐🛐 Do I need to change something for you? |
@olivertzeng yes, please see the inline comments in the GitHub thread |
Okay thanks! |
Fixed |
@olivertzeng it looks like you missed some of the inline comments, still 😄 |
@olivertzeng sorry about all the git-weirdness, it turns out having the automatic translation updates action is nice, but can also create conflicts. 😬 But you should be good to update anything in this branch, and I'll make sure it gets merged correctly. |
👍🏼 |
Ive resolved all the issues you gave and fixed a lot of stuff @cassidyjames |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line 49 has changed
Can you please merge my pr? |
Oh wait it is merged |
Is it @cassidyjames just want to check |
@olivertzeng I'm actively working on fixing the conflicts. :) I plan to merge it today and do a new release soon. |
Great to hear! |
No description provided.