Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New mod: Skills Through Kills #6082

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Coolthulhu
Copy link
Member

@Coolthulhu Coolthulhu commented Feb 13, 2025

Purpose of change (The Why)

Alternative way of gaining skills: murder. "Learn by doing" is, depending on skill, very hard to impossible to balance. Learning knitting by shanking zombies might not be realistic, but is much cleaner design-wise.
Skills Through Kills incentivizes going out and fighting, which should be the focus of the game.

Describe the solution (The How)

New mod that does the following:

  • Disables normal skill gain (for technical reasons, it has to work like this at the moment)
  • Conflicts with Stats From Kills (also technical reasons)
  • Disables booklearning
  • Adds option to increase skills when your kill_xp - total_skill_xp(right_now) > total_skill_xp(with_skill_increased_by_1)

Describe alternatives you've considered

  • Implement booklearning in this PR. It would work by effectively lowering the cost of raising a skill by 25%.
  • Implement NPC learning in this PR. Right now, they just don't gain any xp.
    • Could just have them keep learn-by-doing, but didn't do it here for technical reasons

Testing

  • Start new character with 0 in all skills
  • Try to level a skill - should fail with msg telling you how much xp you need
  • Spawn some big gun and 20 hulks
  • Kill the hulks with the gun
  • Level a skill - it should allow it. It should actually increase the skill too.
  • Level a different skill - the cost should be higher than before, but still within reach

Additional context

Checklist

  • Add xp display somewhere
  • Add xp cost display to skills in @
  • Refine the formula of skill gain so that early game is easy, but late game is hard

Mandatory

@github-actions github-actions bot added src changes related to source code. JSON related to game datas in JSON format. mods PR changes related to mods. labels Feb 13, 2025
@github-actions github-actions bot added the tests changes related to tests label Feb 28, 2025
@Coolthulhu Coolthulhu marked this pull request as ready for review February 28, 2025 22:33
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it errors of missing "xp.h" file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format. mods PR changes related to mods. src changes related to source code. tests changes related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants