-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make census fips codes archiver #507
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd actually suggest archiving the 1990-2000 file, which notes that it was last updated for the 2001 population estimate in the metadata, as year=2001
. We're not planning on extracting anything but the last file in PUDL anyways, so we won't have to deal with extraction but it's relatively straightforward to archive and I don't see an argument for not doing it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A non-blocking comment about the file names, which maybe we want to make consistent with each other and with our other datasets?
some questions/notes:
File "/Users/christinagosnell/code/pudl-archiver/src/pudl_archiver/depositors/zenodo/depositor.py", line 467, in get_deposition
concept_rec_id = concept_doi.split(".")[2]
^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'split' Answer: yes in package_data there is a yaml file. we should also add it to the readme docs
File "/Users/christinagosnell/code/pudl-archiver/src/pudl_archiver/depositors/zenodo/depositor.py", line 526, in run_request
raise ZenodoClientError(
pudl_archiver.depositors.zenodo.depositor.ZenodoClientError: ZenodoClientError(status=400, message=CSRF token missing or incorrect., errors=None)
[1] 96686 exit 1 pudl_archiver --datasets censuspep --initialize --summary-file --sandbox Answer: yes but i needed the right key! bc i had the old one |
Overview
working on catalyst-cooperative/pudl#3884
What problem does this address?
What did you change in this PR?
xls
media type. this was only required for the older files but i'm surprised we've never had to archivexls
files. Did I miss something here?Testing
How did you make sure this worked? How can a reviewer verify this?
I ran
pudl_archiver --datasets censusfips --initialize --summary-file censusfips-summary.json
to make a draft/sandbox archives here:
To-do list
Tasks