-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FERC1 2022 #2948
Merged
Merged
FERC1 2022 #2948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For each context, use the facts associated with this context from the most recent applicable filing.
jdangerx
force-pushed
the
2811-ferc1-2022
branch
from
October 20, 2023 17:36
65ea0ad
to
093b6f8
Compare
zschira
approved these changes
Oct 26, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2948 +/- ##
=====================================
Coverage 88.5% 88.6%
=====================================
Files 91 91
Lines 10808 10854 +46
=====================================
+ Hits 9572 9618 +46
Misses 1236 1236
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This integrates the 2022 FERC1 data into PUDL!
Changes:
ferc-xbrl-extractor==1.2.0
, which loads all XBRL facts into the SQLite files instead of trying to grab facts from only one filing. This necessitates deduplicating the XBRL facts by the XBRL context (entity ID, period, utility type, etc.) and grabbing only the facts from the latest applicable filing.hypothesis
andpandera
to facilitate property-based testing - it's a little slow, so we should use sparingly, but it's a thing we can do now!retained_earnings
- the DBF data includes "previous year" and "current year" data for some factoids, and XBRL only includes "current year." For compatibility across datasets we added the "previous year" data to the XBRL data, but were doing so in a way that assumed only one XBRL year.Once #2947 is merged, we will also have the following changes: