-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename FERC Form 1 core and output assets #2995
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## rename-core-assets #2995 +/- ##
==================================================
Coverage 88.6% 88.6%
==================================================
Files 91 91
Lines 11002 11002
==================================================
Hits 9753 9753
Misses 1249 1249
☔ View full report in Codecov by Sentry. |
FUEL_FERC1 = "core_ferc1__yearly_fuel" | ||
PLANTS_STEAM_FERC1 = "core_ferc1__yearly_plants_steam" | ||
PLANTS_HYDRO_FERC1 = "core_ferc1__yearly_plants_hydro" | ||
PLANTS_SMALL_FERC1 = "core_ferc1__yearly_plants_small" | ||
PLANTS_PUMPED_STORAGE_FERC1 = "core_ferc1__yearly_plants_pumped_storage" | ||
PLANT_IN_SERVICE_FERC1 = "core_ferc1__yearly_plant_in_service" | ||
PURCHASED_POWER_FERC1 = "core_ferc1__yearly_purchased_power" | ||
TRANSMISSION_STATISTICS_FERC1 = "core_ferc1__yearly_transmission_statistics" | ||
ELECTRIC_ENERGY_SOURCES_FERC1 = "core_ferc1__yearly_electric_energy_sources" | ||
ELECTRIC_ENERGY_DISPOSITIONS_FERC1 = ( | ||
"core_ferc1__yearly_electric_energy_dispositions" | ||
STEAM_PLANTS_FUEL = "core_ferc1__yearly_steam_plants_fuel_sched402" | ||
STEAM_PLANTS = "core_ferc1__yearly_steam_plants_sched402" | ||
HYDROELECTRIC_PLANTS = "core_ferc1__yearly_hydroelectric_plants_sched406" | ||
SMALL_PLANTS = "core_ferc1__yearly_small_plants_sched410" | ||
PUMPED_STORAGE_PLANTS = "core_ferc1__yearly_pumped_storage_plants_sched408" | ||
PLANT_IN_SERVICE = "core_ferc1__yearly_plant_in_service_sched204" | ||
PURCHASED_POWER_AND_EXCHANGES = ( | ||
"core_ferc1__yearly_purchased_power_and_exchanges_sched326" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For both the TableId's as well as the table transformer classes, these were all previously a direct translation of the table name. Bc of the info implied by the module (the core == transform, ferc1 = ferc1, ferc1 always yearly), I decided to go with the nugget of the table name instead of the full table name. I also decided to not include the schedule id because this ID is accessible with TableId value which itself is accessible within all of the table transformer classes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I think the only remaining task is to figure out how to rename out__yearly_plants_all_ferc1_plant_parts_eia
.
I'll add a note in the naming convention docs about the sched#s
.
PR Overview
See tasklist and decision on names over in: #2992
PR Checklist
dev
).