-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up Cloud SQL Postgres database for dagster storage #2996
Merged
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
dfea5ef
Set up Cloud SQL postgres database for dagster storage
bendnorman 05901ab
Copy dagster.yaml after DAGSTER_HOME is created
bendnorman 02c52f6
Add proper quoting rules to DAGSTER_PG_PASSWORD secret
bendnorman dcfb8de
Use max cpus for nightly builds and spin dagster-storage SQL instance…
bendnorman ad8442d
Create and delete Cloud SQL db during nightly builds
bendnorman ab9425a
Set PUDL_SETTINGS_YML to etl_full.yml and add git sha to Cloud SQL da…
bendnorman 6592fad
Add short github ref to database name
bendnorman 2f85315
Update DAGSTER_PG_DB with short git sha
bendnorman 1c6dd24
Merge branch 'dev' into setup-dagster-postgres
bendnorman 5b33500
Remove Cloud SQL lifecycle management from gcp_pudl_etl.sh script
bendnorman c15e063
Merge branch 'dev' into setup-dagster-postgres
bendnorman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Set PUDL_SETTINGS_YML to etl_full.yml and add git sha to Cloud SQL da…
…tabase name
- Loading branch information
commit ab9425a332060d67972c3fe649e15fabf5f1ae2a
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be nice to run Postgres in the container itself, so we don't have to do all the weird Cloud SQL lifecycle management stuff.
On the other hand, it is weird to run your application and database in the same container. But gcloud compute only supports one container per VM (unless you want to run docker compose manually on the VM). So I'm OK with the Cloud SQL stuff for now as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on my experience, it seems like it's best to keep the app and database containers separate. I went with Cloud SQL because it's what dagster recommends and it seemed simpler than figuring out how to launch multiple containers.
I guess it's a little strange to spin the database up and down but I don't want to pay for the time it goes unused.