Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix full build notification logic #3058

Merged
merged 5 commits into from
Nov 20, 2023
Merged

Fix full build notification logic #3058

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
848cad1
Add ETL_SUCCESS variable to gcp_pudl_deploy.sh to correctly handle no…
bendnorman Nov 18, 2023
652ea1f
Merge branch 'dev' into fix-gcp-pudl-etl-logic
bendnorman Nov 20, 2023
dfc18f4
Update conda-lock.yml and rendered conda environment files.
bendnorman Nov 20, 2023
5e7aa2f
Merge branch 'dev' into fix-gcp-pudl-etl-logic
bendnorman Nov 20, 2023
cc28b48
Update conda-lock.yml and rendered conda environment files.
bendnorman Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions docker/gcp_pudl_etl.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,23 +91,27 @@ function notify_slack() {
# 2>&1 redirects stderr to stdout.
run_pudl_etl 2>&1 | tee $LOGFILE

ETL_SUCCESS=${PIPESTATUS[0]}

# if pipeline is successful, distribute + publish datasette
if [[ ${PIPESTATUS[0]} == 0 ]]; then
if [[ $ETL_SUCCESS == 0 ]]; then
# Dump outputs to s3 bucket if branch is dev or build was triggered by a tag
if [ $GITHUB_ACTION_TRIGGER = "push" ] || [ $GITHUB_REF = "dev" ]; then
copy_outputs_to_distribution_bucket
ETL_SUCCESS=${PIPESTATUS[0]}
fi

# Deploy the updated data to datasette
if [ $GITHUB_REF = "dev" ]; then
python ~/devtools/datasette/publish.py 2>&1 | tee -a $LOGFILE
ETL_SUCCESS=${PIPESTATUS[0]}
fi
fi

# Notify slack about entire pipeline's success or failure;
# PIPESTATUS[0] either refers to the failed ETL run or the last distribution
# task that was run above
if [[ ${PIPESTATUS[0]} == 0 ]]; then
if [[ $ETL_SUCCESS == 0 ]]; then
notify_slack "success"
else
notify_slack "failure"
Expand Down