Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update expected eia923 row counts to match new outputs. #3954

Closed
wants to merge 1 commit into from

Conversation

zaneselvans
Copy link
Member

Overview

Update expected row counts for EIA-923 tables that were altered through the integration of new EIA-860 & EIA-923 data in our quarterly release.

Testing

How did you make sure this worked? How can a reviewer verify this?

  • Re-ran the ETL locally
  • Ran make pytest-minmax-rows to find discrepancies
  • Updated the expected row-counts to match. Most were a tiny fraction of a percent.
  • gf_eia923 and frc_eia923 were slightly bigger differences -- under expectations by ~0.2% to ~0.3%

To-do list

Preview Give feedback

@zaneselvans zaneselvans added eia923 Anything having to do with EIA Form 923 data-validation Issues related to checking whether data meets our quality expectations. labels Nov 9, 2024
@zaneselvans zaneselvans deleted the fix-eia923-2024Q3-row-counts branch November 10, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data-validation Issues related to checking whether data meets our quality expectations. eia923 Anything having to do with EIA Form 923
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant